github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1810] [MERGED] Fix for missing bio unlock on app restart #9289

New Issue
Closed
opened 2026-04-11 02:17:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:17:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1810
Author: @mpbw2
Created: 2/24/2022
Status: ✅ Merged
Merged: 2/24/2022
Merged by: @mpbw2

Base: master ← Head: bugfix-biolock

📝 Commits (1)

  • 8e3cce3 Fix for missing bio unlock on app restart

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Core/Services/StateService.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

App went directly to unlocked vault, skipping bio unlock prompt on cold start when bio unlock was enabled. Turned out the in-memory bio lock state bool should default to true for the flow to work correctly (overlooked as part of account switching transition)

Code changes

  • StateService.cs: Make BiometricLocked true by default for cold-start bio unlock flow to function correctly

Testing requirements

  1. Set vault timeout to something long-ish (15 minute default is fine)
  2. Set vault timeout action to Lock
  3. Enable biometric unlock support (face, finger, DNA sample, etc.)
  4. Swipe away (kill) app
  5. Launch app. With fix: Biometric unlock prompt will be shown. Without fix: Waltz right into unlocked vault (unless vault timeout period elapsed)

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1810 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/24/2022 **Status:** ✅ Merged **Merged:** 2/24/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-biolock` --- ### 📝 Commits (1) - [`8e3cce3`](https://github.com/bitwarden/android/commit/8e3cce3558863d1a81ecfa3af0a76f91fd379363) Fix for missing bio unlock on app restart ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/StateService.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> App went directly to unlocked vault, skipping bio unlock prompt on cold start when bio unlock was enabled. Turned out the in-memory bio lock state bool should default to true for the flow to work correctly (overlooked as part of account switching transition) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **StateService.cs:** Make `BiometricLocked` true by default for cold-start bio unlock flow to function correctly ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> 1. Set vault timeout to something long-ish (15 minute default is fine) 2. Set vault timeout action to Lock 3. Enable biometric unlock support (face, finger, DNA sample, etc.) 4. Swipe away (kill) app 5. Launch app. With fix: Biometric unlock prompt will be shown. Without fix: Waltz right into unlocked vault (unless vault timeout period elapsed) ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:17:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?