github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 13:29:18 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1751] [MERGED] Fix Account Deletion SSO with CME OTP parameter #9239

New Issue
Closed
opened 2026-04-11 02:16:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:16:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1751
Author: @fedemkr
Created: 2/3/2022
Status: ✅ Merged
Merged: 2/3/2022
Merged by: @fedemkr

Base: master ← Head: account-delete-cme-verification-fix

📝 Commits (1)

  • 80334b8 Fix delete account SSO with CME that the OTP parameter was being sent incorrectly to the server

📊 Changes

7 files changed (+26 additions, -18 deletions)

View changed files

📝 src/Android/MainApplication.cs (+2 -2)
📝 src/App/Pages/Accounts/DeleteAccountViewModel.cs (+2 -5)
📝 src/App/Pages/Accounts/VerificationCodeViewModel.cs (+3 -1)
📝 src/App/Utilities/VerificationActionsFlowHelper.cs (+12 -3)
📝 src/Core/Models/Request/DeleteAccountRequest.cs (+2 -0)
📝 src/Core/Services/UserVerificationService.cs (+2 -4)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+3 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix OTP parameter sent on account deletion of SSO with CME.

Code changes

  • DeleteAccountRequest.cs: Added OTP parameter
  • VerificationActionsFlowHelper: Added more logic to set the verification type on the parameters and also hash the password directly here
  • VerificationCodeViewModel: Set the verification type on the parameters
  • DeleteAccountViewModel.cs -> DeleteAccountActionFlowExecutioner: Updated it to consider passing the master password hash or the OTP parameter to the request.

Testing requirements

A user should be able to delete an account with master password and also with OTP (SSO with CME)

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1751 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/3/2022 **Status:** ✅ Merged **Merged:** 2/3/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `account-delete-cme-verification-fix` --- ### 📝 Commits (1) - [`80334b8`](https://github.com/bitwarden/android/commit/80334b805974ffe65fea93dfa479142a2354c6f7) Fix delete account SSO with CME that the OTP parameter was being sent incorrectly to the server ### 📊 Changes **7 files changed** (+26 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainApplication.cs` (+2 -2) 📝 `src/App/Pages/Accounts/DeleteAccountViewModel.cs` (+2 -5) 📝 `src/App/Pages/Accounts/VerificationCodeViewModel.cs` (+3 -1) 📝 `src/App/Utilities/VerificationActionsFlowHelper.cs` (+12 -3) 📝 `src/Core/Models/Request/DeleteAccountRequest.cs` (+2 -0) 📝 `src/Core/Services/UserVerificationService.cs` (+2 -4) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+3 -3) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix OTP parameter sent on account deletion of SSO with CME. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **DeleteAccountRequest.cs:** Added OTP parameter * **VerificationActionsFlowHelper:** Added more logic to set the verification type on the parameters and also hash the password directly here * **VerificationCodeViewModel:** Set the verification type on the parameters * **DeleteAccountViewModel.cs -> DeleteAccountActionFlowExecutioner:** Updated it to consider passing the master password hash or the OTP parameter to the request. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> A user should be able to delete an account with master password and also with OTP (SSO with CME) ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:16:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?