github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4666] [MERGED] PM-17845 PM-17718 - Enable Remote Configuration for the import flow & Rename Authenticator Sync Feature Flag Name #91690

New Issue
Closed
opened 2026-05-27 08:18:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 08:18:57 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4666
Author: @phil-livefront
Created: 1/31/2025
Status: ✅ Merged
Merged: 2/3/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-17845-Enable-Remote-Configuration-for-the-import-flow

📝 Commits (5)

  • 63ce709 PM-17845 - enable remote configuration for the import flow feature flag
  • 3be6ee7 PM-17717 - Consolidate feature flags for sync between the Password Manager Authenticator
  • 7e7efca fix linter issues
  • eb4e02d fix tests
  • d150bc0 fix tests

📊 Changes

2 files changed (+126 additions, -64 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+124 -62)

📄 Description

🎟️ Tracking

PM-17845
PM-17718

📔 Objective

  • Enable remote configuration for the import-logins-flow feature flag
  • Update Authenticator Sync feature flag name to enable-pm-bwa-sync
  • Update feature flag tests

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4666 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 2/3/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-17845-Enable-Remote-Configuration-for-the-import-flow` --- ### 📝 Commits (5) - [`63ce709`](https://github.com/bitwarden/android/commit/63ce70933a7423b7f1adb780ef0fe8af648818de) PM-17845 - enable remote configuration for the import flow feature flag - [`3be6ee7`](https://github.com/bitwarden/android/commit/3be6ee7273c1ef915a7cc88f11731d7e1d836b54) PM-17717 - Consolidate feature flags for sync between the Password Manager Authenticator - [`7e7efca`](https://github.com/bitwarden/android/commit/7e7efca8aaed85b40a14d2b530c0fd050ea11c73) fix linter issues - [`eb4e02d`](https://github.com/bitwarden/android/commit/eb4e02d0724ec461dfdf6bad42095219949acd3e) fix tests - [`d150bc0`](https://github.com/bitwarden/android/commit/d150bc0ca3766ca218b0e24a81be1f6ac83028a0) fix tests ### 📊 Changes **2 files changed** (+126 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+124 -62) </details> ### 📄 Description ## 🎟️ Tracking [PM-17845](https://bitwarden.atlassian.net/browse/PM-17845) [PM-17718](https://bitwarden.atlassian.net/browse/PM-17718) ## 📔 Objective - Enable remote configuration for the `import-logins-flow` feature flag - Update Authenticator Sync feature flag name to `enable-pm-bwa-sync` - Update feature flag tests ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17845]: https://bitwarden.atlassian.net/browse/PM-17845?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17718]: https://bitwarden.atlassian.net/browse/PM-17718?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 08:18:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#91690