github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-10 05:49:44 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1565] [MERGED] [Reset Password] BUG - Update local policies for enforcement #9109

New Issue
Closed
opened 2026-04-11 02:11:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:11:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1565
Author: @vincentsalucci
Created: 10/7/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @vincentsalucci

Base: master ← Head: m-rpv1-sync

📝 Commits (5)

  • 5c2bbcc [Reset Password] BUG - Update local policies for enforcement
  • 5eb4938 Updated with blocking sync
  • 0763811 add the stuff I forgot to tell vsalucci about
  • 6c491d9 removed the lies I fed vsalucci
  • 95b7757 remove unnecessary import

📊 Changes

3 files changed (+23 additions, -4 deletions)

View changed files

📝 src/App/Pages/Accounts/BaseChangePasswordViewModel.cs (+12 -2)
📝 src/App/Pages/Accounts/UpdateTempPasswordPage.xaml (+4 -1)
📝 src/App/Pages/Accounts/UpdateTempPasswordPage.xaml.cs (+7 -1)

📄 Description

Objective

Fix issue where Master Password Policy isn't being enforced during the Update Temporary Password flow

Code Changes

  • BaseChangePasswordViewModel: Add a forced sync on init if requested. This will get the local policies loaded for potentially enforcing a master password policy.
  • UpdateTempPasswordPage: Send true for forceSync bool.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1565 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 10/7/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-rpv1-sync` --- ### 📝 Commits (5) - [`5c2bbcc`](https://github.com/bitwarden/android/commit/5c2bbcc599e940e7c79896ce533ec1c42fb4e23e) [Reset Password] BUG - Update local policies for enforcement - [`5eb4938`](https://github.com/bitwarden/android/commit/5eb4938d07fbb7889ba668d3df37f8e101d729bc) Updated with blocking sync - [`0763811`](https://github.com/bitwarden/android/commit/07638115a454631eaa1900b06c86120ef6421fd8) add the stuff I forgot to tell vsalucci about - [`6c491d9`](https://github.com/bitwarden/android/commit/6c491d95d6cc27dae8c37bc535dc8aa9b0e488dc) removed the lies I fed vsalucci - [`95b7757`](https://github.com/bitwarden/android/commit/95b7757f59061cf5c17141574249ad3ef0cd962e) remove unnecessary import ### 📊 Changes **3 files changed** (+23 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/BaseChangePasswordViewModel.cs` (+12 -2) 📝 `src/App/Pages/Accounts/UpdateTempPasswordPage.xaml` (+4 -1) 📝 `src/App/Pages/Accounts/UpdateTempPasswordPage.xaml.cs` (+7 -1) </details> ### 📄 Description ## Objective > Fix issue where `Master Password Policy` isn't being enforced during the `Update Temporary Password` flow ## Code Changes - **BaseChangePasswordViewModel**: Add a forced sync on init if requested. This will get the local policies loaded for potentially enforcing a master password policy. - **UpdateTempPasswordPage**: Send `true` for `forceSync` bool. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:11:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9109
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?