github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3751] [MERGED] [PM-10616] create account start design #90969

New Issue
Closed
opened 2026-05-27 06:30:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 06:30:05 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3751
Author: @dseverns-livefront
Created: 8/15/2024
Status: ✅ Merged
Merged: 8/19/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10616/create-account-start-design

📝 Commits (10+)

  • 0ce2b5c PM-10616 update start registration UI to match designs and support help click for server geolocation. Includes PM-10636 implementing padding needed for landscape.
  • e920a76 add feature flag check in landing vm
  • 556e19c fix test
  • 0fc7436 use email verification flag
  • 8da938b pr feedback, add some more tests
  • aeaf3ec mock fix
  • d0f7241 detekt
  • 3352297 add test for custom accessibility actions
  • 8434a3c clean up
  • 0df7a70 fix conflict and chain

📊 Changes

11 files changed (+682 additions, -136 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt (+10 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+244 -121)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModel.kt (+22 -5)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt (+87 -0)
➕ app/src/main/res/drawable-night/vault.xml (+74 -0)
➕ app/src/main/res/drawable/vault.xml (+74 -0)
📝 app/src/main/res/values/strings.xml (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt (+21 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt (+101 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModelTest.kt (+17 -3)
📝 app/src/test/java/com/x8bit/bitwarden/ui/util/ComposeTestHelpers.kt (+30 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10616
&
https://bitwarden.atlassian.net/browse/PM-10636

📔 Objective

Update the StartRegistrationScreen for the new native create account flow

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3751 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/15/2024 **Status:** ✅ Merged **Merged:** 8/19/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10616/create-account-start-design` --- ### 📝 Commits (10+) - [`0ce2b5c`](https://github.com/bitwarden/android/commit/0ce2b5c3972381a7cc3484e01b0826301407ef6f) PM-10616 update start registration UI to match designs and support help click for server geolocation. Includes PM-10636 implementing padding needed for landscape. - [`e920a76`](https://github.com/bitwarden/android/commit/e920a76a70285132a601fb7425fcbac18cdb7e76) add feature flag check in landing vm - [`556e19c`](https://github.com/bitwarden/android/commit/556e19cc5a226e5f9b2387a0b292593e8a86aefc) fix test - [`0fc7436`](https://github.com/bitwarden/android/commit/0fc743682041e6b1ae78d6c87436959775a5c551) use email verification flag - [`8da938b`](https://github.com/bitwarden/android/commit/8da938b842fa29cd92cfe121ad1998d937d00287) pr feedback, add some more tests - [`aeaf3ec`](https://github.com/bitwarden/android/commit/aeaf3ec6eac68c73c52018cc4b38ee3c6afa9953) mock fix - [`d0f7241`](https://github.com/bitwarden/android/commit/d0f7241a8a27329ab34689e6d4f5f4fb07d6a94f) detekt - [`3352297`](https://github.com/bitwarden/android/commit/33522975867da1e4b108751793dff4794b09c8ad) add test for custom accessibility actions - [`8434a3c`](https://github.com/bitwarden/android/commit/8434a3ce0b75036793bf544110f7fb2eb8793a69) clean up - [`0df7a70`](https://github.com/bitwarden/android/commit/0df7a7033aea672ec4d79d0cdcf7324fd82141f1) fix conflict and chain ### 📊 Changes **11 files changed** (+682 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt` (+10 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+244 -121) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModel.kt` (+22 -5) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt` (+87 -0) ➕ `app/src/main/res/drawable-night/vault.xml` (+74 -0) ➕ `app/src/main/res/drawable/vault.xml` (+74 -0) 📝 `app/src/main/res/values/strings.xml` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt` (+21 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt` (+101 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModelTest.kt` (+17 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/util/ComposeTestHelpers.kt` (+30 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10616 & https://bitwarden.atlassian.net/browse/PM-10636 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Update the StartRegistrationScreen for the new native create account flow <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots ![image](https://github.com/user-attachments/assets/c62d82b5-cd55-4762-b40c-05b11b30b4ba) <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 06:30:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#90969