github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-11 04:04:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3444] [MERGED] PM-9408: Show bottom sheet with passkey options #90803

New Issue
Closed
opened 2026-05-27 06:07:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 06:07:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3444
Author: @shannon-livefront
Created: 7/11/2024
Status: ✅ Merged
Merged: 7/22/2024
Merged by: @shannon-livefront

Base: main ← Head: PM-9408-sign-in-with-passkey-bottom-sheet

📝 Commits (3)

  • 30ac91e PM-9408: Show bottom sheet with passkey options
  • 8b287f9 Feedback updates
  • 12a7f7b Feedback updates

📊 Changes

23 files changed (+784 additions, -18 deletions)

View changed files

📝 app/src/debug/AndroidManifest.xml (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt (+8 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+12 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PasskeyAssertionOptions.kt (+15 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PasskeyAttestationOptions.kt (+0 -13)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PublicKeyCredentialDescriptor.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt (+114 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+16 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialSearchUserInterfaceImpl.kt (+37 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+14 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt (+20 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt (+47 -0)
📝 app/src/main/res/values/strings.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt (+40 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt (+273 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt (+63 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialViewUtil.kt (+14 -0)

...and 3 more files

📄 Description

🎟️ Tracking

PM-9408

📔 Objective

Display the bottom sheet with options to ether unlock the vault or select the correct passkey when attempting to authenticate with passkeys.

📸 Screenshots

Unlock the vault if locked:

Select a passkey from the vault if unlocked (note: selecting the item does not yet autofill the credentials as that will be a separate ticket):

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3444 **Author:** [@shannon-livefront](https://github.com/shannon-livefront) **Created:** 7/11/2024 **Status:** ✅ Merged **Merged:** 7/22/2024 **Merged by:** [@shannon-livefront](https://github.com/shannon-livefront) **Base:** `main` ← **Head:** `PM-9408-sign-in-with-passkey-bottom-sheet` --- ### 📝 Commits (3) - [`30ac91e`](https://github.com/bitwarden/android/commit/30ac91ee05b46e504c4e629bc470b57548ba049a) PM-9408: Show bottom sheet with passkey options - [`8b287f9`](https://github.com/bitwarden/android/commit/8b287f95a1ca436d12d034caaf93425cc4063704) Feedback updates - [`12a7f7b`](https://github.com/bitwarden/android/commit/12a7f7be48bc0c615bf7f18c9ff61459a267acd4) Feedback updates ### 📊 Changes **23 files changed** (+784 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `app/src/debug/AndroidManifest.xml` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt` (+8 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+12 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PasskeyAssertionOptions.kt` (+15 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PasskeyAttestationOptions.kt` (+0 -13) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PublicKeyCredentialDescriptor.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt` (+114 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+16 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialSearchUserInterfaceImpl.kt` (+37 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+14 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt` (+20 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt` (+47 -0) 📝 `app/src/main/res/values/strings.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt` (+40 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt` (+273 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt` (+63 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialViewUtil.kt` (+14 -0) _...and 3 more files_ </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> [PM-9408](https://bitwarden.atlassian.net/browse/PM-9408) ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Display the bottom sheet with options to ether unlock the vault or select the correct passkey when attempting to authenticate with passkeys. ## 📸 Screenshots Unlock the vault if locked: <video width="400px" src="https://github.com/bitwarden/android/assets/125921730/bbb7871e-3de0-4d3c-8b02-963b1fdcb271" /> Select a passkey from the vault if unlocked (note: selecting the item does not yet autofill the credentials as that will be a separate ticket): <video width="400px" src="https://github.com/bitwarden/android/assets/125921730/ddd7b177-3baf-4db7-b86c-e3a2529f3e74" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-9408]: https://bitwarden.atlassian.net/browse/PM-9408?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 06:07:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#90803
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?