github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3300] [MERGED] [AC-2788] Remove unassigned items feature flag and logic #90718

New Issue
Closed
opened 2026-05-27 05:54:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 05:54:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3300
Author: @fedemkr
Created: 6/18/2024
Status: ✅ Merged
Merged: 6/19/2024
Merged by: @fedemkr

Base: main ← Head: mobiletf/ac-2788/remove-unassigned-items

📝 Commits (2)

  • 1ff43a0 Revert "[PM-7407] Updates the self-host release date in the unassigned items alert message (#3158)"
  • 7f087d4 AC-2788 Removed unassigned items feature flag and logic introduced in PM-7407.

📊 Changes

19 files changed (+2 additions, -182 deletions)

View changed files

📝 src/Core/Abstractions/IApiService.cs (+0 -1)
📝 src/Core/Abstractions/ICipherService.cs (+0 -1)
📝 src/Core/Abstractions/IStateService.cs (+0 -2)
📝 src/Core/Constants.cs (+0 -2)
📝 src/Core/Models/AppOptions.cs (+0 -1)
📝 src/Core/Pages/Accounts/LockPage.xaml.cs (+0 -5)
📝 src/Core/Pages/Accounts/LoginApproveDevicePage.xaml.cs (+0 -5)
📝 src/Core/Pages/Accounts/LoginPage.xaml.cs (+0 -5)
📝 src/Core/Pages/Accounts/LoginPasswordlessRequestPage.xaml.cs (+0 -5)
📝 src/Core/Pages/Accounts/SetPasswordPage.xaml.cs (+0 -5)
📝 src/Core/Pages/Accounts/TwoFactorPage.xaml.cs (+0 -5)
📝 src/Core/Pages/TabsPage.cs (+1 -1)
📝 src/Core/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+1 -4)
📝 src/Core/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+0 -59)
📝 src/Core/Resources/Localization/AppResources.Designer.cs (+0 -36)
📝 src/Core/Resources/Localization/AppResources.resx (+0 -12)
📝 src/Core/Services/ApiService.cs (+0 -5)
📝 src/Core/Services/CipherService.cs (+0 -18)
📝 src/Core/Services/StateService.cs (+0 -10)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Remove unassigned items banner feature flag and related logic.

Code changes

  • Reverted changes related to Unassigned items banner feature flag + logic.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3300 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 6/18/2024 **Status:** ✅ Merged **Merged:** 6/19/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `main` ← **Head:** `mobiletf/ac-2788/remove-unassigned-items` --- ### 📝 Commits (2) - [`1ff43a0`](https://github.com/bitwarden/android/commit/1ff43a03798814d657eb13750b945261ae8d5df7) Revert "[PM-7407] Updates the self-host release date in the unassigned items alert message (#3158)" - [`7f087d4`](https://github.com/bitwarden/android/commit/7f087d4807b186f9d83238656766f5aa35b47104) AC-2788 Removed unassigned items feature flag and logic introduced in PM-7407. ### 📊 Changes **19 files changed** (+2 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IApiService.cs` (+0 -1) 📝 `src/Core/Abstractions/ICipherService.cs` (+0 -1) 📝 `src/Core/Abstractions/IStateService.cs` (+0 -2) 📝 `src/Core/Constants.cs` (+0 -2) 📝 `src/Core/Models/AppOptions.cs` (+0 -1) 📝 `src/Core/Pages/Accounts/LockPage.xaml.cs` (+0 -5) 📝 `src/Core/Pages/Accounts/LoginApproveDevicePage.xaml.cs` (+0 -5) 📝 `src/Core/Pages/Accounts/LoginPage.xaml.cs` (+0 -5) 📝 `src/Core/Pages/Accounts/LoginPasswordlessRequestPage.xaml.cs` (+0 -5) 📝 `src/Core/Pages/Accounts/SetPasswordPage.xaml.cs` (+0 -5) 📝 `src/Core/Pages/Accounts/TwoFactorPage.xaml.cs` (+0 -5) 📝 `src/Core/Pages/TabsPage.cs` (+1 -1) 📝 `src/Core/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+1 -4) 📝 `src/Core/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+0 -59) 📝 `src/Core/Resources/Localization/AppResources.Designer.cs` (+0 -36) 📝 `src/Core/Resources/Localization/AppResources.resx` (+0 -12) 📝 `src/Core/Services/ApiService.cs` (+0 -5) 📝 `src/Core/Services/CipherService.cs` (+0 -18) 📝 `src/Core/Services/StateService.cs` (+0 -10) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Remove unassigned items banner feature flag and related logic. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * Reverted changes related to Unassigned items banner feature flag + logic. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 05:54:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#90718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?