github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3033] [MERGED] [PM-6309] Fix for 'Show website icons' option not being respected #90554

New Issue
Closed
opened 2026-05-27 05:29:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 05:29:43 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3033
Author: @dinisvieira
Created: 2/25/2024
Status: ✅ Merged
Merged: 2/26/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-6309-fix-for-website-icons-choice-not-respected

📝 Commits (1)

  • 47cddef PM-6309 Fix to ensure the Icon and Icon placeholder visibility states is updated correctly based on website icons visibility choice

📊 Changes

1 file changed (+6 additions, -5 deletions)

View changed files

📝 src/Core/Controls/CipherViewCell/BaseCipherViewCell.cs (+6 -5)

📄 Description

…

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

'Show website icons' option is not being respected.

Code changes

The issue seems to be caused by the Icon_Success setting Icon to visible after loading it without taking into account the current WebsiteIcons setting.

  • BaseCipherViewCell.cs: Updated Icon_Success method to take into account the current WebsiteIcons setting.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3033 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/25/2024 **Status:** ✅ Merged **Merged:** 2/26/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-6309-fix-for-website-icons-choice-not-respected` --- ### 📝 Commits (1) - [`47cddef`](https://github.com/bitwarden/android/commit/47cddef2c3b768a94aae869b6464155de863114d) PM-6309 Fix to ensure the Icon and Icon placeholder visibility states is updated correctly based on website icons visibility choice ### 📊 Changes **1 file changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Controls/CipherViewCell/BaseCipherViewCell.cs` (+6 -5) </details> ### 📄 Description … ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective 'Show website icons' option is not being respected. ## Code changes The issue seems to be caused by the `Icon_Success` setting Icon to visible after loading it without taking into account the current WebsiteIcons setting. * **BaseCipherViewCell.cs:** Updated `Icon_Success` method to take into account the current WebsiteIcons setting. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 05:29:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#90554