github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1625] [MERGED] [SupportedBrowsers] Add Captive Login and drop Alook #89587

New Issue
Closed
opened 2026-05-27 03:15:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 03:15:09 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1625
Author: @stevenlele
Created: 11/2/2021
Status: ✅ Merged
Merged: 11/2/2021
Merged by: @mpbw2

Base: master ← Head: browser-support

📝 Commits (1)

  • ce7adbf [SupportedBrowsers] Add Captive Login and drop Alook

📊 Changes

3 files changed (+5 additions, -5 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+1 -1)
📝 src/Android/Autofill/AutofillHelpers.cs (+1 -1)
📝 src/Android/Resources/xml/autofillservice.xml (+3 -3)

📄 Description

Captive Login

Some android systems show captive login activity (com.google.android.captiveportallogin) when connecting to wireless network. This activity shows URL in its ActionBar subtitle, so there is no view ID.

See: https://cs.android.com/android/platform/superproject/+/master:packages/modules/CaptivePortalLogin/src/com/android/captiveportallogin/CaptivePortalLoginActivity.java;l=600

Alook

This browser was added in https://github.com/bitwarden/mobile/pull/1281, but the developer seems to be unwilling to add auto-fill compatibility. Auto-fill was partially functioning before adding the support, but afterwards it was completely broken (or it might be subject to browser version). Dropping the support might be a good choice.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1625 **Author:** [@stevenlele](https://github.com/stevenlele) **Created:** 11/2/2021 **Status:** ✅ Merged **Merged:** 11/2/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `browser-support` --- ### 📝 Commits (1) - [`ce7adbf`](https://github.com/bitwarden/android/commit/ce7adbfcf83caac68aca829db938f40a04fbf9b3) [SupportedBrowsers] Add Captive Login and drop Alook ### 📊 Changes **3 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+1 -1) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+1 -1) 📝 `src/Android/Resources/xml/autofillservice.xml` (+3 -3) </details> ### 📄 Description ## Captive Login Some android systems show captive login activity (`com.google.android.captiveportallogin`) when connecting to wireless network. This activity shows URL in its ActionBar subtitle, so there is no view ID. See: https://cs.android.com/android/platform/superproject/+/master:packages/modules/CaptivePortalLogin/src/com/android/captiveportallogin/CaptivePortalLoginActivity.java;l=600 ## Alook This browser was added in https://github.com/bitwarden/mobile/pull/1281, but the developer seems to be unwilling to add auto-fill compatibility. Auto-fill was partially functioning before adding the support, but afterwards it was completely broken (or it might be subject to browser version). Dropping the support might be a good choice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 03:15:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#89587