github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 13:07:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1074] [MERGED] check authed before checking if token has premium #89308

New Issue
Closed
opened 2026-05-27 02:32:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 02:32:06 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1074
Author: @kspearrin
Created: 9/18/2020
Status: ✅ Merged
Merged: 9/18/2020
Merged by: @kspearrin

Base: master ← Head: authcheck

📝 Commits (1)

  • b4b1bbb check authed before checking if token has premium

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/Core/Services/UserService.cs (+6 -0)

📄 Description

Any checks to canAccessPremium will throw an exception when not authed since there is no token to reference. This stops it from even trying to access the token.

This is the same as https://github.com/bitwarden/jslib/pull/170

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1074 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 9/18/2020 **Status:** ✅ Merged **Merged:** 9/18/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `authcheck` --- ### 📝 Commits (1) - [`b4b1bbb`](https://github.com/bitwarden/android/commit/b4b1bbb4cf13914510eb9713375bdd9edc47b2da) check authed before checking if token has premium ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/UserService.cs` (+6 -0) </details> ### 📄 Description Any checks to canAccessPremium will throw an exception when not authed since there is no token to reference. This stops it from even trying to access the token. This is the same as https://github.com/bitwarden/jslib/pull/170 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 02:32:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#89308