github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-17 22:12:12 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6618] [MERGED] Remove remember ViewModel #86561

New Issue
Closed
opened 2026-05-23 00:23:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-23 00:23:29 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6618
Author: @david-livefront
Created: 3/5/2026
Status: ✅ Merged
Merged: 3/9/2026
Merged by: @david-livefront

Base: main ← Head: remove-remember-viewmodel

📝 Commits (1)

  • 8b47245 Remove remember ViewModel

📊 Changes

74 files changed (+773 additions, -1521 deletions)

View changed files

📝 .claude/CLAUDE.md (+0 -1)
📝 .claude/skills/implementing-android-code/SKILL.md (+1 -4)
📝 .claude/skills/implementing-android-code/templates.md (+4 -12)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt (+2 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupBrowserAutofillScreen.kt (+12 -17)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupCompleteScreen.kt (+2 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreen.kt (+3 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt (+10 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/environment/EnvironmentScreen.kt (+38 -67)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/expiredregistrationlink/ExpiredRegistrationLinkScreen.kt (+5 -18)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt (+20 -41)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginScreen.kt (+21 -36)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt (+7 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreen.kt (+10 -23)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt (+4 -11)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/masterpasswordhint/MasterPasswordHintScreen.kt (+9 -12)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/preventaccountlockout/PreventAccountLockoutScreen.kt (+2 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordScreen.kt (+7 -16)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/resetpassword/ResetPasswordScreen.kt (+13 -20)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/setpassword/SetPasswordScreen.kt (+9 -16)

...and 54 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR removes all the instances of remeber(viewModel) from the click listeners in the codebase. These extra remebers are no longer needed since strong skipping will handle this for us. This will simplify a lot of our UIs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6618 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/5/2026 **Status:** ✅ Merged **Merged:** 3/9/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `remove-remember-viewmodel` --- ### 📝 Commits (1) - [`8b47245`](https://github.com/bitwarden/android/commit/8b47245268a8e261524cd6df7995143d00143f20) Remove remember ViewModel ### 📊 Changes **74 files changed** (+773 additions, -1521 deletions) <details> <summary>View changed files</summary> 📝 `.claude/CLAUDE.md` (+0 -1) 📝 `.claude/skills/implementing-android-code/SKILL.md` (+1 -4) 📝 `.claude/skills/implementing-android-code/templates.md` (+4 -12) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt` (+2 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupBrowserAutofillScreen.kt` (+12 -17) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupCompleteScreen.kt` (+2 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreen.kt` (+3 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt` (+10 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/environment/EnvironmentScreen.kt` (+38 -67) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/expiredregistrationlink/ExpiredRegistrationLinkScreen.kt` (+5 -18) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt` (+20 -41) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginScreen.kt` (+21 -36) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt` (+7 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreen.kt` (+10 -23) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt` (+4 -11) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/masterpasswordhint/MasterPasswordHintScreen.kt` (+9 -12) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/preventaccountlockout/PreventAccountLockoutScreen.kt` (+2 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordScreen.kt` (+7 -16) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/resetpassword/ResetPasswordScreen.kt` (+13 -20) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/setpassword/SetPasswordScreen.kt` (+9 -16) _...and 54 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR removes all the instances of `remeber(viewModel)` from the click listeners in the codebase. These extra remebers are no longer needed since [strong skipping](https://developer.android.com/develop/ui/compose/performance/stability/strongskipping) will handle this for us. This will simplify a lot of our UIs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-23 00:23:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#86561