github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 00:56:24 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #5846] [MERGED] [PM-25523] Add importCxfPayload to VaultRepository #85928

New Issue
Closed
opened 2026-05-22 22:51:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 22:51:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5846
Author: @SaintPatrck
Created: 9/5/2025
Status: ✅ Merged
Merged: 9/5/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-25523/vault-repo-import-cxf

📝 Commits (1)

📊 Changes

4 files changed (+87 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+8 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+15 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/model/ImportCxfPayloadResult.kt (+21 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+43 -0)

📄 Description

🎟️ Tracking

PM-25523

📔 Objective

This commit introduces the importCxfPayload function to the VaultRepository interface and its implementation, VaultRepositoryImpl. This function allows for importing vault data from a CXF (Cipher Export Format) payload.

The key changes include:

  • Defining importCxfPayload in VaultRepository.
  • Implementing importCxfPayload in VaultRepositoryImpl, which involves:
    • Retrieving the active user ID.
    • Calling vaultSdkSource.importCxf to process the payload.
    • Calling ciphersService.importCiphers to import the processed ciphers.
    • Triggering a sync operation upon successful import.
  • Introducing ImportCxfPayloadResult sealed class to represent the outcome of the import operation (Success or Error).
  • Adding a corresponding unit test in VaultRepositoryTest to verify the success scenario of importCxfPayload.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5846 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/5/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-25523/vault-repo-import-cxf` --- ### 📝 Commits (1) - [`9f68e87`](https://github.com/bitwarden/android/commit/9f68e871396dce9d88cc10b1bc2840c2e4945a55) [PM-25523] Add `importCxfPayload` to `VaultRepository` ### 📊 Changes **4 files changed** (+87 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+8 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+15 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/model/ImportCxfPayloadResult.kt` (+21 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+43 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-25523] ## 📔 Objective This commit introduces the `importCxfPayload` function to the `VaultRepository` interface and its implementation, `VaultRepositoryImpl`. This function allows for importing vault data from a CXF (Cipher Export Format) payload. The key changes include: - Defining `importCxfPayload` in `VaultRepository`. - Implementing `importCxfPayload` in `VaultRepositoryImpl`, which involves: - Retrieving the active user ID. - Calling `vaultSdkSource.importCxf` to process the payload. - Calling `ciphersService.importCiphers` to import the processed ciphers. - Triggering a sync operation upon successful import. - Introducing `ImportCxfPayloadResult` sealed class to represent the outcome of the import operation (Success or Error). - Adding a corresponding unit test in `VaultRepositoryTest` to verify the success scenario of `importCxfPayload`. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-25523]: https://bitwarden.atlassian.net/browse/PM-25523?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 22:51:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#85928
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?