github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #139] [MERGED] Add UWP support #8583

New Issue
Closed
opened 2026-04-11 01:57:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 01:57:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/139
Author: @hichamboushaba
Created: 9/29/2017
Status: ✅ Merged
Merged: 10/3/2017
Merged by: @kspearrin

Base: master ← Head: master

📝 Commits (10+)

📊 Changes

104 files changed (+1171 additions, -72 deletions)

View changed files

📝 bitwarden-mobile.sln (+74 -10)
📝 src/Android/Android.csproj (+2 -2)
📝 src/Android/packages.config (+1 -1)
📝 src/App/App.csproj (+2 -2)
📝 src/App/Controls/ExtendedTableView.cs (+1 -1)
📝 src/App/Pages/EnvironmentPage.cs (+1 -1)
📝 src/App/Pages/HomePage.cs (+2 -2)
📝 src/App/Pages/Lock/LockFingerprintPage.cs (+1 -1)
📝 src/App/Pages/Lock/LockPasswordPage.cs (+1 -1)
📝 src/App/Pages/LoginPage.cs (+1 -1)
📝 src/App/Pages/MainPage.cs (+4 -4)
📝 src/App/Pages/PasswordHintPage.cs (+1 -1)
📝 src/App/Pages/RegisterPage.cs (+5 -5)
📝 src/App/Pages/ScanPage.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsAboutPage.cs (+2 -2)
📝 src/App/Pages/Settings/SettingsAddFolderPage.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsEditFolderPage.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsFeaturesPage.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsHelpPage.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsListFoldersPage.cs (+3 -3)

...and 80 more files

📄 Description

Hi, this is the first PR for UWP support, the application can compile and run (tested on a laptop with Windows CU).

The main changes to the PCL project:

The interfaces IGoogleAnalyticsService and IDeviceActionService are still not implemented.
And the application still uses the default theme which needs some tweaking.

#9

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/139 **Author:** [@hichamboushaba](https://github.com/hichamboushaba) **Created:** 9/29/2017 **Status:** ✅ Merged **Merged:** 10/3/2017 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`d0f80de`](https://github.com/bitwarden/android/commit/d0f80de9ff9e31ff43da868cba5953b6cd27ec17) Add UWP project, and generate services boilerplate - [`9f95a37`](https://github.com/bitwarden/android/commit/9f95a3732505fa024a308d70bbf8c24b747cee5c) SqliteService implementation and sqlite-net-pcl update (#bug https://stackoverflow.com/questions/45418669/xamarin-forms-pcl-assemly-issue) - [`f763a4e`](https://github.com/bitwarden/android/commit/f763a4e037c285c8c8c1b0de4a900c4425b4cf3d) Important services implementation - [`57f4618`](https://github.com/bitwarden/android/commit/57f4618a2730430f2336b32404b66b525259715a) Create a shared project to host images for UWP (to keep code project clean) - [`fefa5cd`](https://github.com/bitwarden/android/commit/fefa5cdec5ef1ca11cd4a5ebd7e282ec20e3d008) Add extensions to image names referenced by the pcl project - [`2880b30`](https://github.com/bitwarden/android/commit/2880b30a326de9a5d593862ca23f5c0704ce1c85) Add DismissModalToolBarItem to modal pages - [`c2afa27`](https://github.com/bitwarden/android/commit/c2afa273ed8974d06ab33d78e056f96af9759cb2) moving UWP folders inside src folder - [`52c5dbf`](https://github.com/bitwarden/android/commit/52c5dbfaf243df237dbea926f09957490ccbf9df) Add DeviceInfoService implementation - [`625c77b`](https://github.com/bitwarden/android/commit/625c77b3dbd872cf366f1f20b9901887e4e84ce3) Remove dependency on BouncyCastle, and calculate key derivation using native support - [`57fe1b1`](https://github.com/bitwarden/android/commit/57fe1b1c4911c15b63d0b38e41a8ac1686b51035) changes requested by project maintener ### 📊 Changes **104 files changed** (+1171 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `bitwarden-mobile.sln` (+74 -10) 📝 `src/Android/Android.csproj` (+2 -2) 📝 `src/Android/packages.config` (+1 -1) 📝 `src/App/App.csproj` (+2 -2) 📝 `src/App/Controls/ExtendedTableView.cs` (+1 -1) 📝 `src/App/Pages/EnvironmentPage.cs` (+1 -1) 📝 `src/App/Pages/HomePage.cs` (+2 -2) 📝 `src/App/Pages/Lock/LockFingerprintPage.cs` (+1 -1) 📝 `src/App/Pages/Lock/LockPasswordPage.cs` (+1 -1) 📝 `src/App/Pages/LoginPage.cs` (+1 -1) 📝 `src/App/Pages/MainPage.cs` (+4 -4) 📝 `src/App/Pages/PasswordHintPage.cs` (+1 -1) 📝 `src/App/Pages/RegisterPage.cs` (+5 -5) 📝 `src/App/Pages/ScanPage.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsAboutPage.cs` (+2 -2) 📝 `src/App/Pages/Settings/SettingsAddFolderPage.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsEditFolderPage.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsFeaturesPage.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsHelpPage.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsListFoldersPage.cs` (+3 -3) _...and 80 more files_ </details> ### 📄 Description Hi, this is the first PR for UWP support, the application can compile and run (tested on a laptop with Windows CU). The main changes to the PCL project: - Adding extensions to image names. - Updating sqlite-pcl-net to version 1.5.166-beta to solve this bug: https://stackoverflow.com/questions/45497992/pcl-vs-net-standard-library-for-sqlite-in-uwp The interfaces _IGoogleAnalyticsService_ and _IDeviceActionService_ are still not implemented. And the application still uses the default theme which needs some tweaking. #9 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 01:57:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#8583
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?