github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-18 14:41:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4010] [MERGED] [PM-13073] Handle Fido2 credential errors on vault unlock screen #84446

New Issue
Closed
opened 2026-05-22 19:37:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 19:37:58 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4010
Author: @SaintPatrck
Created: 10/1/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-13073/handle-fido2-errors

📝 Commits (3)

  • a98640e [PM-13073] Handle Fido2 credential errors on vault unlock screen
  • 5d5dfc0 Merge remote-tracking branch 'origin/main' into PM-13073/handle-fido2-errors
  • dc963c8 Update VaultUnlockScreen.kt

📊 Changes

4 files changed (+127 additions, -5 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt (+18 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt (+36 -3)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt (+30 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModelTest.kt (+43 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13073

📔 Objective

This commit adds logic to handle Fido2 credential errors on the vault
unlock screen.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4010 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 10/1/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-13073/handle-fido2-errors` --- ### 📝 Commits (3) - [`a98640e`](https://github.com/bitwarden/android/commit/a98640e11ae7e2c946143e1806bd741027fc1ba9) [PM-13073] Handle Fido2 credential errors on vault unlock screen - [`5d5dfc0`](https://github.com/bitwarden/android/commit/5d5dfc070c454735a2a8d35d7c9858ba20ba8fcf) Merge remote-tracking branch 'origin/main' into PM-13073/handle-fido2-errors - [`dc963c8`](https://github.com/bitwarden/android/commit/dc963c820ab15389076180b549e875939b0b75e3) Update VaultUnlockScreen.kt ### 📊 Changes **4 files changed** (+127 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt` (+18 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt` (+36 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt` (+30 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModelTest.kt` (+43 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13073 ## 📔 Objective This commit adds logic to handle Fido2 credential errors on the vault unlock screen. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 19:37:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#84446