github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-17 08:58:36 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2605] [CLOSED] [PM-2900] Added two extra dark themes options DarkPlus and SolarizedDarkBlue #83512

New Issue
Closed
opened 2026-05-22 17:29:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 17:29:25 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2605
Author: @KeshavPratap-K
Created: 7/8/2023
Status: ❌ Closed

Base: master ← Head: Additional-Dark-themes-for-mobile-app

📝 Commits (4)

  • 6cd4e96 Added two extra dark themes options DarkPlus and SolarizedDarkBlue
  • 17bb88d Merge branch 'master' into Additional-Dark-themes-for-mobile-app
  • ef97f3b Merge branch 'master' into Additional-Dark-themes-for-mobile-app
  • bd3a424 Merge branch 'master' into Additional-Dark-themes-for-mobile-app

📊 Changes

9 files changed (+224 additions, -5 deletions)

View changed files

📝 src/Android/Utilities/ThemeHelpers.cs (+1 -1)
📝 src/App/Pages/Settings/OptionsPageViewModel.cs (+4 -0)
📝 src/App/Resources/AppResources.Designer.cs (+25 -4)
📝 src/App/Resources/AppResources.resx (+8 -0)
➕ src/App/Styles/DarkPlus.xaml (+76 -0)
➕ src/App/Styles/DarkPlus.xaml.cs (+12 -0)
➕ src/App/Styles/SolarizedDarkBlue.xaml (+76 -0)
➕ src/App/Styles/SolarizedDarkBlue.xaml.cs (+12 -0)
📝 src/App/Utilities/ThemeManager.cs (+10 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

These two need dark themes are added to give Bitwarden mobile app a refreshed look. One DarkPlus is inspired from GitHub dark mode and Solarized DarkBlue is inspired from existing Solarized Dark theme to be in blue.

Code changes

  • ThemeHelpers.cs - Added conditions to existing code to make light theme specific style false as added two themes are dark mode theme.
  • OptionsPageViewModel.cs - Added Values to existing theme selector in options page.
  • AppResources.Designer.cs - System generated due to changes made in below file.
  • AppResources.resx - Added Value to display and comment for new theme in option menu.
  • DarkPlus.xaml - DarkPlus theme style definition.
  • DarkPlus.xaml.cs - To initialize DarkPlus theme.
  • SolarizedDarkBlue.xaml - Solarized DarkBlue theme style definition.
  • SolarizedDarkBlue.xaml.cs - To initialize Solarized DarkBlue theme.
  • ThemeManager.cs - Code to change theme style for added themes. Used existing functions.

Screenshots

Dark+ LoginPage

Solarized DarkBlue LoginPage

Dark+ Password

Solarized DarkBlue Password

Dark+ Password generator

[olarized DarkBlue Password generator

Dark+ HomePage

Solarized DarkBlue HomePage

Options theme Value Dark+

Options theme Value Solarized DarkBlue

Settings

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2605 **Author:** [@KeshavPratap-K](https://github.com/KeshavPratap-K) **Created:** 7/8/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Additional-Dark-themes-for-mobile-app` --- ### 📝 Commits (4) - [`6cd4e96`](https://github.com/bitwarden/android/commit/6cd4e9683f5ef75581f6a46c6ed3a23b336c0e9b) Added two extra dark themes options DarkPlus and SolarizedDarkBlue - [`17bb88d`](https://github.com/bitwarden/android/commit/17bb88d4aaafa153e28efc5d5afbc0cd0b7b6ce0) Merge branch 'master' into Additional-Dark-themes-for-mobile-app - [`ef97f3b`](https://github.com/bitwarden/android/commit/ef97f3bca98fc937b6d2d57053bcd2154c7c2200) Merge branch 'master' into Additional-Dark-themes-for-mobile-app - [`bd3a424`](https://github.com/bitwarden/android/commit/bd3a4246d1139a7c6a6c8a5812b46c9fe6310ce6) Merge branch 'master' into Additional-Dark-themes-for-mobile-app ### 📊 Changes **9 files changed** (+224 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Utilities/ThemeHelpers.cs` (+1 -1) 📝 `src/App/Pages/Settings/OptionsPageViewModel.cs` (+4 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+25 -4) 📝 `src/App/Resources/AppResources.resx` (+8 -0) ➕ `src/App/Styles/DarkPlus.xaml` (+76 -0) ➕ `src/App/Styles/DarkPlus.xaml.cs` (+12 -0) ➕ `src/App/Styles/SolarizedDarkBlue.xaml` (+76 -0) ➕ `src/App/Styles/SolarizedDarkBlue.xaml.cs` (+12 -0) 📝 `src/App/Utilities/ThemeManager.cs` (+10 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective These two need dark themes are added to give Bitwarden mobile app a refreshed look. One DarkPlus is inspired from GitHub dark mode and Solarized DarkBlue is inspired from existing Solarized Dark theme to be in blue. ## Code changes * **ThemeHelpers.cs** - Added conditions to existing code to make light theme specific style false as added two themes are dark mode theme. * **OptionsPageViewModel.cs** - Added Values to existing theme selector in options page. * **AppResources.Designer.cs** - System generated due to changes made in below file. * **AppResources.resx** - Added Value to display and comment for new theme in option menu. * **DarkPlus.xaml** - DarkPlus theme style definition. * **DarkPlus.xaml.cs** - To initialize DarkPlus theme. * **SolarizedDarkBlue.xaml** - Solarized DarkBlue theme style definition. * **SolarizedDarkBlue.xaml.cs** - To initialize Solarized DarkBlue theme. * **ThemeManager.cs** - Code to change theme style for added themes. Used existing functions. ## Screenshots <img src="https://github.com/bitwarden/mobile/assets/47635515/c2fb54e7-e66c-4b3c-9a7e-ee9c39f4a208" height="600"> <p align = "left"> <b>Dark+ LoginPage</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/bb8ac6de-b6ae-4522-bbb1-e2f097f048cd" height="600"> <p align = "left"> <b>Solarized DarkBlue LoginPage</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/264f4cd0-6c45-404f-bc5c-2defc2b45f8b" height="600"> <p align = "left"> <b>Dark+ Password</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/2d357d2c-0b33-44cb-bdc3-f3ec8a9dd1fe" height="600"> <p align = "left"> <b>Solarized DarkBlue Password</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/328329ce-867e-4ee9-b021-e8a1e2a7dbb8" height="600"> <p align = "left"> <b>Dark+ Password generator</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/48963cd2-80dc-4226-bdae-440dbf42142c" height="600"> <p align = "left"> <b>[olarized DarkBlue Password generator</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/74aaecc3-3358-4a84-9a59-29f49bfaef2e" height="600"> <p align = "left"> <b>Dark+ HomePage</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/0685c66b-3756-4dce-9294-9a87e61de14f" height="600"> <p align = "left"> <b>Solarized DarkBlue HomePage</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/2d5ef9cd-dda5-492a-b94e-6579b5b8be4f" height="600"> <p align = "left"> <b>Options theme Value Dark+</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/6117f70f-7895-49bd-9aac-037fe59e6ddb" height="600"> <p align = "left"> <b>Options theme Value Solarized DarkBlue</b> </p> <img src="https://github.com/bitwarden/mobile/assets/47635515/064a0824-cf2a-4ab3-981f-9ae335bb5b40" height="600"> <p align = "left"> <b>Settings</b> </p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 17:29:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#83512