github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-21 00:33:17 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6923] [MERGED] [PM-32806] feat: Add Add/Edit support for Passport item type #82211

New Issue
Closed
opened 2026-05-19 20:45:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 20:45:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6923
Author: @SaintPatrck
Created: 5/14/2026
Status: ✅ Merged
Merged: 5/15/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-32806_addedit-passport

📝 Commits (4)

  • 3d862d3 PM-32806 feat: Add Add/Edit support for Passport item type
  • 1d0cf4c Drop unwired Passport date handlers
  • e2fb243 Introduce rememberVaultAddEditPassportTypeHandlers helper
  • 9aaa825 Wire Passport into the save-flow cipher type mapping

📊 Changes

9 files changed (+951 additions, -22 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+9 -1)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditPassportItems.kt (+213 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+4 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+125 -2)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditPassportTypeHandlers.kt (+134 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+4 -3)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+181 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+197 -16)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt (+84 -0)

📄 Description

🎟️ Tracking

📔 Objective

Replace the Passport stub in the Add/Edit flow with the full editor so people can save Passport items through the normal create/edit flow. Inputs cover the 13 fields exposed by the SDK's PassportView; sensitive values (passportNumber, nationalIdentificationNumber) reveal-toggle via BitwardenPasswordField, and the three date fields reuse the License date selection stub pending the shared native picker. The Passport state's isSdkSupported override is removed so the normal save path runs end-to-end.

📸 Screenshots

Figma Actual

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6923 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/14/2026 **Status:** ✅ Merged **Merged:** 5/15/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-32806_addedit-passport` --- ### 📝 Commits (4) - [`3d862d3`](https://github.com/bitwarden/android/commit/3d862d3c683d87332cf7b53c02990139b1ad27f9) [PM-32806] feat: Add Add/Edit support for Passport item type - [`1d0cf4c`](https://github.com/bitwarden/android/commit/1d0cf4cdd211799577ce1f7b6aadeebbd8c10033) Drop unwired Passport date handlers - [`e2fb243`](https://github.com/bitwarden/android/commit/e2fb243afe9dc657087156f5da336cec9ad6ec45) Introduce rememberVaultAddEditPassportTypeHandlers helper - [`9aaa825`](https://github.com/bitwarden/android/commit/9aaa8250c38a4d8e430e731a3056463ff9d15075) Wire Passport into the save-flow cipher type mapping ### 📊 Changes **9 files changed** (+951 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+9 -1) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditPassportItems.kt` (+213 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+4 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+125 -2) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditPassportTypeHandlers.kt` (+134 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+4 -3) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+181 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+197 -16) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt` (+84 -0) </details> ### 📄 Description ## 🎟️ Tracking - Jira: [PM-32806](https://bitwarden.atlassian.net/browse/PM-32806) ## 📔 Objective Replace the Passport stub in the Add/Edit flow with the full editor so people can save Passport items through the normal create/edit flow. Inputs cover the 13 fields exposed by the SDK's `PassportView`; sensitive values (`passportNumber`, `nationalIdentificationNumber`) reveal-toggle via `BitwardenPasswordField`, and the three date fields reuse the License date selection stub pending the shared native picker. The Passport state's `isSdkSupported` override is removed so the normal save path runs end-to-end. ## 📸 Screenshots | Figma | Actual | |--------|--------| | <img width="365" src="https://github.com/user-attachments/assets/f69fb68f-7726-4b45-b7f7-5b0b879c6a98" /> | <img width="365" src="https://github.com/user-attachments/assets/5b8f92ab-e999-412e-a840-0aded39ae3f8" /> | [PM-32806]: https://bitwarden.atlassian.net/browse/PM-32806?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 20:45:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#82211