github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-11-10 01:15:13 -06:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6916] [MERGED] PM-36508: Chore: Local network access permission #82205

New Issue
Closed
opened 2026-05-19 20:45:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 20:45:01 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6916
Author: @david-livefront
Created: 5/13/2026
Status: ✅ Merged
Merged: 5/15/2026
Merged by: @david-livefront

Base: main ← Head: PM-36508-local-network-access-permission

📝 Commits (2)

  • 4aca01e PM-36508: Target API 37
  • 6d3506e PM-36508: Add support for requesting LocalNetworkAccess permission

📊 Changes

31 files changed (+1220 additions, -10 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt (+9 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt (+24 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/network/di/PlatformNetworkModule.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+12 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkPermissionManager.kt (+21 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkPermissionManagerImpl.kt (+49 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/util/ThrowableExtensions.kt (+2 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessNavigation.kt (+40 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessScreen.kt (+204 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessViewModel.kt (+99 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/handlers/LocalNetworkAccessHandler.kt (+44 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt (+25 -3)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkPermissionManagerTest.kt (+134 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryTests.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/util/ThrowableExtensionsTest.kt (+8 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessScreenTest.kt (+163 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessViewModelTest.kt (+83 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt (+8 -0)
📝 gradle/libs.versions.toml (+2 -2)

...and 11 more files

📄 Description

🎟️ Tracking

PM-36508

📔 Objective

This PR updates the targetSdk & compileSdk to 37. Support for requesting the ACCESS_LOCAL_NETWORK permission has been added via a top-level overlay.

📸 Screenshots

| | |

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6916 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 5/13/2026 **Status:** ✅ Merged **Merged:** 5/15/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-36508-local-network-access-permission` --- ### 📝 Commits (2) - [`4aca01e`](https://github.com/bitwarden/android/commit/4aca01efa58999e525ca14f33baf66c1bce501e3) PM-36508: Target API 37 - [`6d3506e`](https://github.com/bitwarden/android/commit/6d3506eadbca93efc65433ba66dadac4c916a795) PM-36508: Add support for requesting LocalNetworkAccess permission ### 📊 Changes **31 files changed** (+1220 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt` (+9 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt` (+24 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/network/di/PlatformNetworkModule.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+12 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkPermissionManager.kt` (+21 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkPermissionManagerImpl.kt` (+49 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/util/ThrowableExtensions.kt` (+2 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessNavigation.kt` (+40 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessScreen.kt` (+204 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessViewModel.kt` (+99 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/handlers/LocalNetworkAccessHandler.kt` (+44 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt` (+25 -3) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkPermissionManagerTest.kt` (+134 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryTests.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/util/ThrowableExtensionsTest.kt` (+8 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessScreenTest.kt` (+163 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/localnetworkaccess/LocalNetworkAccessViewModelTest.kt` (+83 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt` (+8 -0) 📝 `gradle/libs.versions.toml` (+2 -2) _...and 11 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-36508](https://bitwarden.atlassian.net/browse/PM-36508) ## 📔 Objective This PR updates the `targetSdk` & `compileSdk` to 37. Support for requesting the `ACCESS_LOCAL_NETWORK` permission has been added via a top-level overlay. ## 📸 Screenshots | <img width="350" src="https://github.com/user-attachments/assets/bb889e7a-87af-4bfc-b9e1-3ce2bc00ff78" /> | <img width="350" src="https://github.com/user-attachments/assets/278d9adf-c175-41fe-935e-d45e69241b8d" /> | [PM-36508]: https://bitwarden.atlassian.net/browse/PM-36508?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 20:45:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#82205