github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-21 00:33:17 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6875] [MERGED] [PM-32810] feat: Add Bank Account item detail view #82177

New Issue
Closed
opened 2026-05-19 20:42:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 20:42:48 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6875
Author: @SaintPatrck
Created: 5/5/2026
Status: ✅ Merged
Merged: 5/6/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-32810_bank-account-view

📝 Commits (2)

  • c8b871e PM-32810 feat: Add Bank Account item detail view
  • bfcd3f6 Drop unused VaultBankAccountType.stringNameOrNull

📊 Changes

12 files changed (+1552 additions, -11 deletions)

View changed files

➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemBankAccountContent.kt (+439 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt (+19 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+216 -3)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultBankAccountItemTypeHandlers.kt (+71 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt (+3 -2)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/util/VaultBankAccountTypeExtensions.kt (+28 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+305 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+337 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultBankAccountItemTypeHandlersTest.kt (+96 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensionsTest.kt (+1 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/util/VaultBankAccountTypeExtensionsTest.kt (+30 -0)
📝 ui/src/main/res/values/strings.xml (+7 -2)

📄 Description

🎟️ Tracking

PM-32810

Stacked child: #6877

📔 Objective

Surface the read-only Bank Account detail screen so existing Bank Account ciphers can be opened from any list and have their fields copied. This PR is the detail-screen slice of the original Bank Account view-only feature; the vault-list, item-listing, and search surfaces follow in the stacked child PR.

📸 Screenshots

Figma: https://www.figma.com/design/WjD06w9dFlA67Ba27d1OSu/Dev-Ready--Bitwarden-Android?node-id=40015437-424812&t=I5hzVA3NUII5Fx6B-4

Actual:
|

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6875 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/5/2026 **Status:** ✅ Merged **Merged:** 5/6/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-32810_bank-account-view` --- ### 📝 Commits (2) - [`c8b871e`](https://github.com/bitwarden/android/commit/c8b871e3432e75679750c1117ff77bdfc8b7699c) [PM-32810] feat: Add Bank Account item detail view - [`bfcd3f6`](https://github.com/bitwarden/android/commit/bfcd3f63e9b420213110e147e5cc454634778f2c) Drop unused VaultBankAccountType.stringNameOrNull ### 📊 Changes **12 files changed** (+1552 additions, -11 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemBankAccountContent.kt` (+439 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt` (+19 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+216 -3) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultBankAccountItemTypeHandlers.kt` (+71 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt` (+3 -2) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/util/VaultBankAccountTypeExtensions.kt` (+28 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+305 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+337 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultBankAccountItemTypeHandlersTest.kt` (+96 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensionsTest.kt` (+1 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/util/VaultBankAccountTypeExtensionsTest.kt` (+30 -0) 📝 `ui/src/main/res/values/strings.xml` (+7 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-32810](https://bitwarden.atlassian.net/browse/PM-32810) Stacked child: #6877 ## 📔 Objective Surface the read-only Bank Account detail screen so existing Bank Account ciphers can be opened from any list and have their fields copied. This PR is the **detail-screen slice** of the original Bank Account view-only feature; the vault-list, item-listing, and search surfaces follow in the stacked child PR. ## 📸 Screenshots Figma: https://www.figma.com/design/WjD06w9dFlA67Ba27d1OSu/Dev-Ready--Bitwarden-Android?node-id=40015437-424812&t=I5hzVA3NUII5Fx6B-4 Actual: <img width="365" src="https://github.com/user-attachments/assets/330aca65-c364-4191-b532-b8438df6b267" /> | [PM-32810]: https://bitwarden.atlassian.net/browse/PM-32810?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 20:42:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#82177