github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 20:47:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6852] [MERGED] [PM-32808] feat: View License item type #82157

New Issue
Closed
opened 2026-05-19 20:41:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 20:41:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6852
Author: @SaintPatrck
Created: 4/29/2026
Status: ✅ Merged
Merged: 5/12/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-32808_drivers-license

📝 Commits (4)

  • 1bc6a61 PM-32808 feat: Add Driver's License item type
  • a40a234 PM-32808 test: Cover Driver's License view screen and null-guard branches
  • 15b37a3 Rename "Drivers License" vault item type to "License"
  • 66a0a86 Fix failing test

📊 Changes

25 files changed (+1360 additions, -65 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/model/CreateVaultItemType.kt (+14 -14)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/util/CreateVaultItemTypeExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/model/CustomFieldType.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/VaultAddEditExtensions.kt (+1 -1)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemDriversLicenseContent.kt (+418 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt (+20 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+147 -2)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultDriversLicenseItemTypeHandlers.kt (+55 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt (+11 -8)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/components/util/CreateVaultItemTypeExtensionsTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+5 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+274 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+235 -0)

...and 5 more files

📄 Description

🎟️ Tracking

  • PM-32808 — License item type
  • Parent epic: PM-32009 — New Item Types
  • Child PR: #6908 — License Add/Edit support

📔 Objective

Adds the read-only View screen for the License cipher type so users can open an existing license and review its fields. Renders first / middle / last name with copy affordances, license number as a sensitive field with show/hide and copy, date of birth, issuing country, issuing state / province, issuing authority, issue date, expiration date, and license class.

📸 Screenshots

Figma Actual

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6852 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 5/12/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-32808_drivers-license` --- ### 📝 Commits (4) - [`1bc6a61`](https://github.com/bitwarden/android/commit/1bc6a6148ae01f0b7be0602d73b5f411f67e6c2f) [PM-32808] feat: Add Driver's License item type - [`a40a234`](https://github.com/bitwarden/android/commit/a40a2342d1172da149bfa60c7b16698a159bcc61) [PM-32808] test: Cover Driver's License view screen and null-guard branches - [`15b37a3`](https://github.com/bitwarden/android/commit/15b37a333a489e007dfe80873ed8e81f883d8dcb) Rename "Drivers License" vault item type to "License" - [`66a0a86`](https://github.com/bitwarden/android/commit/66a0a86ae4c4b5cebaf8a1f720ca829632944aaa) Fix failing test ### 📊 Changes **25 files changed** (+1360 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/model/CreateVaultItemType.kt` (+14 -14) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/util/CreateVaultItemTypeExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/model/CustomFieldType.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/VaultAddEditExtensions.kt` (+1 -1) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemDriversLicenseContent.kt` (+418 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt` (+20 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+147 -2) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultDriversLicenseItemTypeHandlers.kt` (+55 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt` (+11 -8) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/components/util/CreateVaultItemTypeExtensionsTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+5 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+274 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+235 -0) _...and 5 more files_ </details> ### 📄 Description ## 🎟️ Tracking - [PM-32808](https://bitwarden.atlassian.net/browse/PM-32808) — License item type - Parent epic: [PM-32009](https://bitwarden.atlassian.net/browse/PM-32009) — New Item Types - Child PR: #6908 — License Add/Edit support ## 📔 Objective Adds the read-only View screen for the License cipher type so users can open an existing license and review its fields. Renders first / middle / last name with copy affordances, license number as a sensitive field with show/hide and copy, date of birth, issuing country, issuing state / province, issuing authority, issue date, expiration date, and license class. ## 📸 Screenshots | Figma | Actual | |--------|--------| | <img width="365" src="https://github.com/user-attachments/assets/cd5993ce-5531-4612-8350-57be002ae9ad" /> | <img width="365" src="https://github.com/user-attachments/assets/d73f8ef6-40e4-49a4-8a22-72f1e427cbe8" /> | | <img width="365" src="https://github.com/user-attachments/assets/1812b478-b2d7-422d-9b1a-e0061d9198bb" /> | <img width="365" src="https://github.com/user-attachments/assets/1fc16ad8-f52e-4910-ba3c-e770e49bf649" /> | [PM-32808]: https://bitwarden.atlassian.net/browse/PM-32808?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-32009]: https://bitwarden.atlassian.net/browse/PM-32009?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 20:41:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#82157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?