github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-15 08:34:16 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6693] [MERGED] PM-33893: bug: Crash caused by empty credential password #82030

New Issue
Closed
opened 2026-05-19 20:31:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 20:31:40 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6693
Author: @david-livefront
Created: 3/19/2026
Status: ✅ Merged
Merged: 3/19/2026
Merged by: @david-livefront

Base: main ← Head: PM-33893-empty-password-crash

📝 Commits (1)

  • 40c9822 PM-33893: Crash caused by empty credential password

📊 Changes

7 files changed (+101 additions, -23 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/credentials/manager/CredentialProviderCompletionManagerImpl.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/credentials/manager/model/GetPasswordCredentialResult.kt (+5 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+21 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/credentials/manager/CredentialProviderCompletionManagerTest.kt (+6 -3)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+4 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+62 -9)
📝 ui/src/main/res/values/strings.xml (+1 -0)

📄 Description

🎟️ Tracking

PM-33893

📔 Objective

This PR addresses a crash that occurs when the password is null or empty.

This is because the PasswordCredential requires the password to be populated.

    init {
        require(password.isNotEmpty()) { "password should not be empty" }
    }

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6693 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/19/2026 **Status:** ✅ Merged **Merged:** 3/19/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-33893-empty-password-crash` --- ### 📝 Commits (1) - [`40c9822`](https://github.com/bitwarden/android/commit/40c98224a9f50f12c0f41fa15d5053de9c152ddd) PM-33893: Crash caused by empty credential password ### 📊 Changes **7 files changed** (+101 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/credentials/manager/CredentialProviderCompletionManagerImpl.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/credentials/manager/model/GetPasswordCredentialResult.kt` (+5 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+21 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/credentials/manager/CredentialProviderCompletionManagerTest.kt` (+6 -3) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+4 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+62 -9) 📝 `ui/src/main/res/values/strings.xml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-33893](https://bitwarden.atlassian.net/browse/PM-33893) ## 📔 Objective This PR addresses a crash that occurs when the password is null or empty. This is because the `PasswordCredential` requires the password to be populated. ```kotlin init { require(password.isNotEmpty()) { "password should not be empty" } } ``` [PM-33893]: https://bitwarden.atlassian.net/browse/PM-33893?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 20:31:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#82030