github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6358] [MERGED] [PM-30644] Removing special circumstance validation from MigrateToMyItems route #81754

New Issue
Closed
opened 2026-05-19 20:11:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 20:11:56 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6358
Author: @aj-rosado
Created: 1/14/2026
Status: ✅ Merged
Merged: 1/23/2026
Merged by: @aj-rosado

Base: main ← Head: PM-30644/share-totp-should-display-item-migration

📝 Commits (5)

  • 6fade4e removing special circumstance validation from MigrateToMyItems route
  • 9c074cd Merge branch 'main' into PM-30644/share-totp-should-display-item-migration
  • 6e7ab2a Changing logic to skip special circumstances on Vault Migration
  • f1fe20c Improved shouldShowVaultMigration readibility by changing to a when
  • dff97fa made shouldShowVaultMigration when exhaustive

📊 Changes

2 files changed (+125 additions, -19 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt (+45 -19)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt (+80 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30644

📔 Objective

Only scenario that should not trigger the migration from the SpecialCircumstance is the Autofill. It is already above the navigation to the migration so we should not have the special circumstance check here.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6358 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 1/14/2026 **Status:** ✅ Merged **Merged:** 1/23/2026 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-30644/share-totp-should-display-item-migration` --- ### 📝 Commits (5) - [`6fade4e`](https://github.com/bitwarden/android/commit/6fade4eec74bbfe7cc0d2f59d0cb1d5b3293384e) removing special circumstance validation from MigrateToMyItems route - [`9c074cd`](https://github.com/bitwarden/android/commit/9c074cd9509166da8ae47fe15a3abe0b7206f327) Merge branch 'main' into PM-30644/share-totp-should-display-item-migration - [`6e7ab2a`](https://github.com/bitwarden/android/commit/6e7ab2a44fe6331b1c68560cfaf18369d15fa9ee) Changing logic to skip special circumstances on Vault Migration - [`f1fe20c`](https://github.com/bitwarden/android/commit/f1fe20cc877a051a27f881fc6bd560f76c03a573) Improved shouldShowVaultMigration readibility by changing to a when - [`dff97fa`](https://github.com/bitwarden/android/commit/dff97facd1acd8b516b7b597d20f711c8ff9c5eb) made shouldShowVaultMigration when exhaustive ### 📊 Changes **2 files changed** (+125 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt` (+45 -19) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt` (+80 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-30644 ## 📔 Objective Only scenario that should not trigger the migration from the SpecialCircumstance is the Autofill. It is already above the navigation to the migration so we should not have the special circumstance check here. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 20:11:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#81754