mirror of
https://github.com/bitwarden/android.git
synced 2026-03-12 05:04:17 -05:00
Connecting to a server with TLS Client Authentication crashes app #808
Closed
opened 2025-11-26 22:30:26 -06:00 by GiteaMirror
·
68 comments
No Branch/Tag Specified
main
sdlc/sdk-update
fix/PM-33394-throwable-extensions
fix/PM-33394-sync-unlock-error
PM-24380/flight-recorder-redact-hostname
release/2026.3-rc48
claude/android-implementer-agent
PM-26577-app-links-support
PM-26896-autofill-fix
renovate/lock-file-maintenance
release/2026.2-rc47
PM-32714/fallback-to-web-vault-host
pr-6572
PM-28834/setting-app-layout-horizonos
vvolkgang/process-release-notes-v2
release/2026.2-rc46
release/2026.1-rc45
PM-30644/added-logs-for-debug
PM-30644/quicktile-nav-not-showing-migration
minor-gradle-updates
release/2026.1-rc42
release/2026.1-rc44
release/2026.1-rc43
PM-28834/set-landscape-on-horizonos-devices
context-rules
devclarity/update-code-review-command
PM-20026/force-ltr-passwords-and-codes
release/2025.12-rc41
cmcg/testCoverage
claude-skill/creating-feature-flags
PM-29014/talkback-support-for-passwords
release/2025.12-rc40
BRE-1305/publish_test
accept-user-certs
autofill-permissions
release/2025.11-rc39
PM-22479/check-all-certificates-validate-asset-links
release/2025.10-rc38
agalles/android-latest
optimize-test-workflows
tier2-test-sharding
retro-agent
PM-27001/skip-account-selection-only-one-exists-cxp
release/2025.10-rc37
agalles/test-1118
release/2025.10-rc36
PM-20593-token-refresh
QA-1126b/adding-native-sanity-test
release/2025.9-rc35
pm-25933/sdk-update-password
release/2025.9-rc34
release/2025.8-rc33
agalles/20250821-release
debug-release-issues
pm-24249-allow-automated-prs-for-sdk-updates
release/2025.8-rc32
release/WORKFLOW-TEST-2025.8-rc28
agalles/20250807release
release/2025.07-rc25
release/hotfix-v2025.7.0-bwa
pm-23311/export-vault-policy-bypass
release/2025.07-rc24
authenticator-pm-sync-flags-issue
ps/implement-sdk-repository-example
release/hotfix-v2025.6.0-bwpm
release/2025.06-rc21
agalles/automate-android-fastlane-patch
release/2025.05-rc20
release/2025.04-rc19
languages/basque
release/2025.03-rc19
update-readme
qrcode/feature
innovation/archive/pm-19153-archive-items
qrcode/2-ui-fields
qrcode/1-page
hold-on-biometric-prompt-alternative
release-notes-process
release/2025.02-rc16
bwa-monorepo
PM-8223/new-device-verification-ux-improvements
pm-18451/exempt-from-policies
test-bwa
cs-workaround-linked-0-copy
release/2025.01-rc15
release/2025.01-rc14
release/2024.12-rc13
pm-16670/sync-leave-notice
821
PM-16695/backport-lean-more-new-device-verification
km/15084-testing
release/hotfix-v2024.11.7
release/2024.11-rc1
pm-11304/collection-add-item-button
PM-14241/disabling-logs-app-crash
poc/offline-editing
new-version-calc
pm-11649/expired-link-services
pm-6702/add-feature-flag
pm-6702/email-verification-feature
pm-9933/marketing-copy-update
pm-6702/registration-flows
update-templates
pm-6701/email-verification-selfhost-registration
v2026.2.1-bwpm
v2026.2.1-bwa
v2026.2.0-bwpm
v2026.2.0-bwa
v2026.1.1-bwa
v2026.1.1-bwpm
temp-test
v2026.1.0-bwpm
v2026.1.0-bwa
v2025.12.1-bwa
v2025.12.1-bwpm
v2025.12.0-bwa
v2025.12.0-bwpm
v2025.11.1-bwpm
v2025.11.1-bwa
v2025.11.0-bwpm
v2025.11.0-bwa
v2025.10.1-bwa
v2025.10.1-bwpm
v2025.10.0-bwa
v2025.10.0-bwpm
v2025.9.1-bwa
v2025.9.1-bwpm
v2025.9.0-bwa
v2025.9.0-bwpm
v2025.8.1-bwa
v2025.8.1-bwpm
v2025.8.0-bwa
v2025.8.0-bwpm
v2025.7.2-bwa
v2025.7.2-bwpm
v2025.7.1-bwa
v2025.7.1-bwpm
v2025.7.0-bwa
v2025.7.0-bwpm
v2025.6.1-bwpm
v2025.6.0-bwa
v2025.6.0-bwpm
v2025.1.0-bwa
v2025.5.0-bwa
v2025.5.0-bwpm
v2025.5.999
2025.4.0
v2025.4.0
untagged-4731eaadac73f3dfbbb8
v2025.3.0
v2025.2.0
untagged-815a165c5d70ffe75bc7
v2025.1.2
v2025.1.1
v2025.1.0
v2024.12.0
untagged-5a76b6392a4c8998c63a
v2024.11.7
v2024.11.6
v2024.11.5
v2024.11.4
v2024.11.3
v2024.11.2
v2024.11.1
v2024.11.0
v2024.10.2
v2024.10.1
v2024.10.0
v2024.9.0
v2024.8.1
v2024.8.0
v2024.7.3
v2024.7.2
v2024.7.1
v2024.7.0
v2024.6.1
v2024.6.0
v2024.5.1
v2024.4.1
v2024.4.2
v2024.4.0
v2024.3.3
v2024.3.1
v2024.3.0
v2024.2.1
v2024.2.0
v2024.1.1
v2024.1.0
v2023.12.0
v2023.10.0
v2023.9.2
maui-single-project-android
v2023.9.1
v2023.9.0
v2023.8.0
v2023.7.0
v2023.5.0
v2023.4.0
v2023.3.2
v2023.3.1
v2023.3.0
v2023.2.0
v2023.1.0
v2022.11.0
v2022.10.0
v2022.9.1
v2022.9.0
v2022.8.0
v2022.6.2
v2022.6.1
v2022.6.0
v2022.05.0
v2.18.0
v2.17.0
v2.16.4
v2.16.3
v2.16.2
v2.16.1
v2.15.0
v2.14.2
v2.14.1
v2.14.0
v2.13.0
v2.12.0
v2.11.3
v2.11.2
v2.11.1
v2.11.0
v2.10.0
v2.9.1
v2.9.0
v2.8.2
v2.8.1
v2.8.0
v2.7.2
v2.7.0
v2.6.1
v2.6.0
v2.5.6
v.2.5.5
v2.5.5
v2.5.4
v2.5.3
v2.5.2
v2.5.1
v2.5.0
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.1
v2.3.0
v2.2.8
v2.2.7
v2.2.6
v2.2.2
v2.2.1
v2.2.0
v2.1.2
v2.1.0
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v1.22.1
v1.22.0
v1.21.0
v1.20.0
v1.19.0
v1.18.1
v1.18.0
v1.17.0
v1.16.0
v1.15.2
v1.15.1
v1.15.0
v1.14.4
v1.14.1
v1.14.0
v1.13.0
v1.12.2
v1.12.1
v1.12.0
v1.11.1
v1.11.0
v1.10.0
v1.9.0
v1.8.1
v1.8.0
v1.7.0
v1.6.5
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v1.4.4
v1.4.3
v1.4.0
v1.3.0
v1.2.1
v1.2.0
v1.1.0
v1.0.0
v0.0.6
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
No Label
help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/android#808
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @codingJWilliams on GitHub (Aug 21, 2019).
Hello,
When connecting to a Bitwarden server that's behind an nginx proxy that requires a client cert, the app just crashes when pressing the Log In button. The same server works fine on Firefox, requesting access to my certificate as expected, and when I disable the requirement to have client authentication through my reverse proxy, the app works fine too.
I see this is a known issue based on a few forum posts (https://community.bitwarden.com/t/client-certificates/427, https://community.bitwarden.com/t/mobile-app-cant-access-server-behind-reverse-proxy-with-client-cert-authentification/2071 etc) so thought I'd raise an issue.
@agboom commented on GitHub (Aug 27, 2019):
Hi, I have the same use case and a similar experience that you have @codingJWilliams. It would be a nice addition to the mobile app to support TLS client authentication. The added security would be beneficial for on-premise deployments.
Perhaps we can join forces and come up with an implementation that could be merged into mainline?
@kspearrin Could you give your opinion on this and maybe some pointers on where to start?
@kspearrin commented on GitHub (Aug 27, 2019):
All server communication happens with httpclient here: https://github.com/bitwarden/mobile/blob/master/src/Core/Services/ApiService.cs
I am not sure what is needed to support client certificates.
@agboom commented on GitHub (Aug 27, 2019):
Thanks for your quick answer and the pointer. I'll have a stab at it, but first I'll need to setup a C# dev environment on Linux. I'm quite new to C# development, so if anyone has any experience to share, I'd be much obliged. My first bet is Rider from Jetbrains, let's hope this works 🤞.
@kspearrin commented on GitHub (Aug 27, 2019):
Unfortunately, there is no Xamarin support on Linux that I know of.
@agboom commented on GitHub (Aug 27, 2019):
It seems to be one of the advertised features of Rider: https://www.jetbrains.com/rider/features/
I'll let you know if it works out.
@codingJWilliams commented on GitHub (Aug 27, 2019):
Hello,
Thank you for the very kind offer @agboom but I'm rather hopeless at C#!
I did some basic research and this does seem to be possible with the System.Net.HttpClient but I wouldn't know where to start with implementing this - if you need any help testing or similar, however, please let me know.
I will take a shot however this does seem to be outside of my comfort zone.
@agboom commented on GitHub (Aug 28, 2019):
Thanks @codingJWilliams I'll give a shout if there's something to test or otherwise.
My main challenge right now is to get the dev environment working on Linux which is new to me for C#. The Jetbrains Rider IDE requires a paid license which is a bummer, because it's currently my only chance of Xamarin development on Linux AFAIK. Jetbrains does offer free licenses to open source project contributors, so maybe hope @kspearrin?
@codingJWilliams commented on GitHub (Aug 28, 2019):
Hello,
I've been able to make some progress on this - it's rather crude and doesn't use the system certificate selection dialog but I have at least been able to get the app to connect. Inside the ApiService.cs I have modified the HttpClient definition to the following:
Then, I added the
modernhttpclient-updatedNuGet package and built the app, which was then able to connect to my server.One thing I would note is that I'm not quite sure of the implications of
DangerousAcceptAnyServerCertificateValidator = truehowever without this I could not get the HttpClient to accept my server's certificate - even explicitly adding the certificate as described by https://libraries.io/nuget/modernhttpclient-updated. Will make an issue on their end to look into this - could be because I use a wildcard*.voidcrafted.meSSL certificate.It's hacky, but works, so possibly a good starting point. I would ideally like this to be able to use certificates installed on the system rather than needing access to the pfx file though.
@agboom commented on GitHub (Aug 29, 2019):
Thanks for picking this up @codingJWilliams, I've been out of luck with Xamarin on Linux. Although I could start a trail period with Jetbrains Rider, the Xamarin SDK did not work out of the box and requires some packages that failed to install on my system.
Great that you got it working! My guess for the implications of
DangerousAcceptAnyServerCertificateValidatoris that the client possibly accepts certs from any certificate authority, similar to where you would add an exception for an unknown cert in Firefox or Chrome, except in this case all certs are accepted. If that's the case theDangerousprefix is appropriate, since it defeats the purpose of having TLS.If the HttpClient indeed does accept your server certificate that could be a bug. Just thinking out loud here: did you try to add the CA cert?
Not sure how the system certificates could be used, but I agree that it is the desired functionality.
@mzpqnxow commented on GitHub (Oct 12, 2019):
Is there any development continuing on this? This is something I am very interested in
Unfortunately, I am also not at all a C# developer nor have I done any mobile platform development before, so I don't think I would be very helpful either, unless someone can point me towards how to set up a Linux development environment.
I can't imagine the code would be that complicated, seems the UI portion would be more work than the logic. The way I would expect the UI to work would be to have an option/dialog for "Identity" where installed client certificates could be selected from, much in the way that iPhone EAP-TLS functions
I can try to get a simple environment up that will allow me to at least write a bare bones "tls_connect" function with an optional client certificate, but I would have to pass that off to someone familiar with the UI portion, and familiar with the iOS/Android APIs for selecting the certificates from the device
EDIT: https://thomasbandt.com/certificate-and-public-key-pinning-with-xamarin seems to be a useful resource
@mzpqnxow commented on GitHub (Oct 12, 2019):
@codingJWilliams I agree that using an "installed" system certificate would be ideal, but I would be happy with the .pfx/.p12 as a start (and I think that's a reasonable way to implement it, so long as it doesn't get in the way of the UI options most commonly used)
@mzpqnxow commented on GitHub (Oct 20, 2019):
@kspearrin is TLS client certificate authentication something you are willing to support? This would be great for hosted instances
EDIT: Currently TLS client certificate auth works fine with BitWarden via web browser. It is just the iOS application I am talking about here!
I'm sorry to hijack the thread here, but I tried to organize some thoughts about it, hoping you would be willing to listen and consider. If you prefer this in a separate issue, or communication via another medium, please let me know!
The Problem
First, there is not a problem with the authentication mechanisms of BitWarden for users. It currently supports very strong methods of authentication, which protect users from account takeovers. These work very well to accomplish what they set out to do
However, some users and organizations would like a way to proactively protect a hosted BitWarden server from pre-authentication attacks on the BitWarden HTTP based application. A successful attack making use of a vulnerability in BitWarden could be disastrous for an organization, due to the nature of the product. While secrets are encrypted on the server, an attacker who compromised the web infrastructure could very easily capture login credentials from users and then... well, you know.
There are some other options users and organizations have (VPNs, Firewalls, Layer 7 filters/controls, etc) but none are as simple or elegant as mutually authenticated TLS for solving this problem. Especially in the age of MDM, where many organizations have the ability to push "identity" certificates to managed devices, TLS client authentication becomes something that is available "for free"
TLS Client-Certificate Authentication Support - The Benefits
The Use Cases
Suggested Implementation
Assuming this discussion is worth having, here are some thoughts on implementation approaches. I see two ways to do this without making it into an unnecessarily large project, and without impacting existing UX
Effort Involved
The second approach is obviously better as it's less work and does not disturb workflow or UX for users that do not require this feature. The amount of development involved seems to me to be relatively small, unless the framework(s) being used are terribly flawed in facilitating this functionality
Because I do not know what the APIs provide you with, I can give a quick low-level summary of what happens in the connection when a client certificate is required, in case you are not familiar with the SSL/TLS handshake. This should give you an idea of what you would need from an API
TLS Client HelloServer Hello,Certificate,Server Key ExchangeandCertificate Request[1]Certificateresponse to theCertificate Requestfrom the server[1] For a "normal" HTTPS server, the
Certificate Requestmessage would only flow from client to server. This is what allows the API to know it needs to present a certificate during the handshakeThanks for reading through this, I'm happy to help out any way I can. Especially if that means writing this in shorter form :>
@kspearrin commented on GitHub (Oct 20, 2019):
@mzpqnxow I don't doubt that this would be a good idea to add, however, priorities don't align for me to look into this further at the moment. I've added the "help wanted" tag here if someone wants to contribute to the feature. Ideally we'd somehow use a a cert on the device without having to prompt a user to pick it.
@mzpqnxow commented on GitHub (Oct 21, 2019):
Fair enough, thank you. And I agree with that approach.
@mzpqnxow commented on GitHub (Oct 21, 2019):
@agboom , @codingJWilliams any interest/time in picking this up again? Any luck on getting a no-cost dev environment up in Linux so that I might be able to help?
@MrLuje commented on GitHub (Jan 1, 2020):
I started to look at the android implementation. Unfortunately, I'm better with SSL in C# than java so I didn't find a way to use device's certificates without prompting the user to choose one.
I made some tests with pfx protected certificate, when the api call fails with ssl errors, it asks the user for a certificate. The certificate is then installed on device KeyChain so we can reuse it next time without having to ask the certificate credentials again (screenshots of the flow at the end)
You can take a look at the code here : https://github.com/MrLuje/mobile/tree/android-tls-auth
https://user-images.githubusercontent.com/632075/71647255-4f29c000-2cf4-11ea-995f-379df82fb8de.png
https://user-images.githubusercontent.com/632075/71647256-5650ce00-2cf4-11ea-82bc-ddbfc00001a7.png
https://user-images.githubusercontent.com/632075/71647258-5650ce00-2cf4-11ea-91b2-9d659c8e9f5f.png
https://user-images.githubusercontent.com/632075/71647259-56e96480-2cf4-11ea-9aac-504928c7b629.png
@codingJWilliams commented on GitHub (Jan 2, 2020):
Hello,
Sorry for dropping this, I didn't see the email about this. I think that's all very promising progress, and your implementation does look good @MrLuje , thanks for the hard work on that. From a UX standpoint your implementation looks good as well, essentially just the normal dialog that chrome prompts with. Once I'm back at my desktop tomorrow I'll test your build of that.
Thanks for being interested in implementing this guys, best open source contributors <3
@daveKCS commented on GitHub (Jan 9, 2020):
For Android, in order to avoid the cert prompting, you need to specify your own KeyManager to SSLContext. The KeyManager - which could be derived from X509ExtendedKeyManager - needs to have the key pair alias and private key entry (KeyStore.PrivateKeyEntry) set in it, so that the alias can be returned by "chooseClientAlias", and the private key entry can be used for "getPrivateKey" and "getCertificateChain". I can provide a Java sample of the if you are interested.
@mzpqnxow commented on GitHub (Feb 1, 2020):
I really appreciate the time you put into this @MrLuje
I see you put clean stubs in for iOS. I'm not experienced at all with Xamarin/.NET so wanted to ask if it is correct to assume that the iOS implementation will need to be mostly/completely different for this? I know Xamarin provides abstraction, but maybe that's less relevant when it comes to crypto features, which I assume aren't quite 1:1 on Android vs iOS
@MrLuje commented on GitHub (Feb 3, 2020):
I'm not experienced enough with iOS to tell (and I have no device to build/test it), I have a rough idea about how to implement the http client part, but I don't know what is possible to do with iOS regarding certificates. That's also why I'm not pushing the android version further (except if we can have feature-discrepancy between iOS & Android)
@mzpqnxow commented on GitHub (Feb 26, 2020):
@MrLuje I see.. thanks.
FWIW to those on this issue, I'm willing to offer a small bounty for anyone who will implement the iOS support (and actually get a PR accepted upstream and into the AppStore build) .. maybe $500USD? Any takers? ;)
@mKamleiter commented on GitHub (Sep 21, 2020):
Hey,
just want to give this a push.
Would be a very nice feature for Android and iOS
@mzpqnxow commented on GitHub (Sep 25, 2020):
I hereby increase the bounty to... $501USD!
@rnowak commented on GitHub (Feb 26, 2021):
Greetings,
I would like to inquire about the status of this issue. Ideally, the (iOS/Android) client would be able to select a client certificate from the system store (or even an in-app option would be fine, really) and present it to the reverse proxy that will be running in front of the Bitwarden server software. I have no expectation for the Bitwarden server software to do anything with it.
Is the resolution of this issue on any roadmap or is it stale?
Thank you.
@foxfire881 commented on GitHub (Jan 29, 2022):
hi guys, i aslo need TLS mutual authentication, then i find this topic.
fortunately, I am familiar with C#.NET on Windows, but I am not familiar with Xamarin.NET on iOS and Android, but I think they are similar.
it is very easy to send http requests with client certificate by HttpClient, i write these code and test it successfully on Windows.
it runs well on my test:
so, on iOS/Android, the key step is to get the client certificate, then you can send it with HttpClient.
one way to get the client certificate in Bitwarden App, i think it could prompt a certificate list window to let user select his certificate(just like chrome/edge browser);
the other way to get the client certificate, Bitwarden App could use a simple "while" loop to iterate through the certificates installed on mobile device to get the right one which signed by CA(for example: the "Subject Altname" section in client certificate must equal or contains the domain name of the target site)
for the reason i am not familiar with Xamarin on iOS/Android, i hope you guys could continue this work to implement TLS mutual authentication on mobile device, it will be very useful and more and more security.
@kspearrin
@foxfire881 commented on GitHub (Feb 10, 2022):
hi guys, is there any update for this? @kspearrin @vincentsalucci @jlf0dev @eliykat
@jiin995 commented on GitHub (Jun 28, 2022):
+1
@TheAlaine commented on GitHub (Jul 19, 2022):
+1
@scottsavarese commented on GitHub (Sep 22, 2022):
@kspearrin , I see folks love to tag you on this thread...
Is the issue with getting this resolved due to not having a good way to test out client certs? I know nothing about developing on an Android (or mobile in general), but would be happy to help in any way I can. I can side load test versions, I can help create a server that you can use to test out client certs. I just really want to see this working. it works with other platforms. No reason it can't work on Android too.
@superuser866 commented on GitHub (Nov 24, 2022):
@MrLuje has solved this problem 3 years ago. His code is working perfectly out of the box.
Why does Bitwarden team ignore such an important implementation in those times where security is more important than ever??
@dbosompem commented on GitHub (Nov 25, 2022):
Hi all, apologies for all the inconveniences caused. The team will make time and pick this up, and get back to you on what we discover. Thanks for the patience!
@montdidier commented on GitHub (Nov 26, 2022):
Do you know where his implementation is now? The link he provides goes to 404?
Update. Never mind, it looks like it is here
@Pythoner6 commented on GitHub (Dec 23, 2022):
Definitely looking forward to this. I'm self hosting and would much rather only expose that to the internet only behind mutual tls auth.
@lpcvoid commented on GitHub (Dec 27, 2022):
Absolutely thrilled about seeing progress here. Thanks in advance to the team and everybody involved!
@leranp commented on GitHub (Jan 1, 2023):
Tried to compile with the changes, but it didn't work, the code was changed a lot since than and it can't compile with the add-on of the certificate.
Did someone manage to do it?
@cpainchaud commented on GitHub (Feb 3, 2023):
I am craving for this as well. Right now I am forced into Wireguard split tunneling instead
@montdidier commented on GitHub (Feb 15, 2023):
I never tried his code. I had my own, basically working, for Android then realised the other solution was more elegant as it as was using the native store for the certificates. I started looking at the iOS side but got a new job and whoosh there went my time. When the core team sounded like they were going to pick this up I wasn’t particularly motivated to continue. It does seem to be taking its time to arrive though. 🤔
This is the only missing feature in my want list for this app.
@cpainchaud commented on GitHub (Feb 15, 2023):
guys, in the meantime don't expose bitwarden to internet and use Wireguard on your computer+Android. Use split tunneling to send only Bitwarden traffic to it.
@ITTV-tools commented on GitHub (Mar 22, 2023):
Any news on this ?
@mpbw2 commented on GitHub (Mar 22, 2023):
Hello all, the work done by @MrLuje looks promising. @MrLuje would you be willing/able to bring your PR up to date so you get credit for the work?
@volmus commented on GitHub (Apr 8, 2023):
@MrLuje Looking forward to hear from you! :-) 🍺
@dayt47 commented on GitHub (Jun 6, 2023):
any updates on this topic?
@superuser866 commented on GitHub (Jun 7, 2023):
I did it. I have little experience in vb.net but managed somehow to install all the stuff needed and compiled @MrLuje 's code months ago .
It may be an old client version but it works flawlessly.
If you want I can send the compiled APK to you and to others who wish.
@scottsavarese commented on GitHub (Jun 7, 2023):
Any chance you can create a new pull request for it? This way the devs can review and merge it.
@ippocratis commented on GitHub (Jun 16, 2023):
@superuser866 did you cherry picked
7fd95c21abon a bitwarden upstream source?In that case can create a pull request for it?
I just builded straight from https://github.com/MrLuje/mobile.git
There are like 90 warnings but no errors
The source is outdated of coarse but for the time being I'm OK with it
I just hope @MrLuje or someone else comes with an up to date pull request
@oguzhane commented on GitHub (Jul 19, 2023):
i've implemented support of mTLS client authentication based off latest code base. see following short demo below.
happy to raise a PR for that.. @kspearrin @mpbw2
https://github.com/bitwarden/mobile/assets/4419532/90b4b89e-fbc3-4114-8ab2-72c447223feb
@leranp commented on GitHub (Jul 19, 2023):
Great news @oguzhane , can you share it with us?
@mpbw2 commented on GitHub (Jul 19, 2023):
@oguzhane That looks fantastic, and we'd be happy to review the PR when you submit it.
@ippocratis commented on GitHub (Jul 20, 2023):
@oguzhane the app hangs and crashes while picking up the client certificate from the android cert store
If the file manager is used then it can import the cert corectly
Also note that there is a generic p12 importing issue in recent android versions for certs created with openssl v3
I had to convert it to "legacy" so I could import it
@oguzhane commented on GitHub (Jul 20, 2023):
@ippocratis thanks for testing this out.
To make further investing for installation from system certs. Can i please ask;
if you install a cert in pkcs#12 legacy format to system cert store and then, use it on the app, do you still getting issue?
@ippocratis commented on GitHub (Jul 20, 2023):
Android 13 LineageOS 20 custom rom , rooted
Settings >security>encryption and cedentials>install a certificate
Sorry if I wasn't clear.
Thats what I meant.
Entered my email selected selfhosted under region
Continue
Advanced
There are two options under udvanced
It is the second option that is failing
Also I forgot to mention that I have to clear app data after that to be able to use the app again
Error on logcat
It is a pkcs 12 bundle
Yes
sudo openssl pkcs12 -info -nodes -in /storage/emulated/0/certs/client_cert.p12The "original" pkcs12 cant be saved in the android system store
It is password protected and the system can't decrypt the password
The legacy cert is installed on android certificate store
And the one that crashes the app if the second option is used (as described above)
@oguzhane commented on GitHub (Jul 21, 2023):
I'm able to install a certificate to system store and use it from the app. The system was able to decrypt the cert and the app can pick this one up to use. # 1 # 2 # 3 # 4
$ openssl pkcs12 -info -nodes -in client.b.pfxI think the issue here seem to be either your cert's encryption type not supported or related to LineageOS.
Following is commands i use to generate client certificate from ca. it produces pem file. you have to convert to pfx that recognized by Android.
@vvolkgang commented on GitHub (Jun 20, 2024):
Issue migrated to https://github.com/bitwarden/mobile/issues/582
@kuolemaaa commented on GitHub (Nov 25, 2024):
is there an update for this? I got
Exception message: Read error: [...] Failure in SSL library, usually a protocol error [...] TLSV1_ALERT_CERTIFICATE_REQUIRED [...]I use an installed p12 certificate on chrome and it works there, not on bitwarden app (latest from playstore).
MIUI 14
Android 13
@mathieuruellan commented on GitHub (Nov 27, 2024):
@kuolemaaa i've the same issue.
@vvolkgang commented on GitHub (Nov 27, 2024):
👋🏾 The original issue here was in the legacy apps that were moved to bitwarden/mobile, if this is happening in the new native app please create a new bug report and we'll look into it!
@kuolemaaa commented on GitHub (Nov 27, 2024):
@vvolkgang just for clarification:
As far as I can understand there is already an issue for mTLS in bitwarden/mobile here https://github.com/bitwarden/mobile/issues/582
An AFAICU there are problems with mTLS in the new bitwarden/android native app (basically not supported at all).
Also there is a closed/not merged Pull Request for that here https://github.com/bitwarden/android/pull/2629#issuecomment-1881333854 with that comment telling users something about PR not in the direction of the project and stuff.
Do we need to reopen an issue for mTLS support for bitwarden/android ? Is it necessary ?
@vvolkgang commented on GitHub (Nov 27, 2024):
This repo used to be bitwarden/mobile and was renamed to bitwarden/android, everything was migrated to the new bitwarden/mobile but you'll still find old references here too. This issue was automatically closed during that migration process. I know this is confusing but I hope that explains it.
Those statements were regarding the legacy codebase and don't apply to the new native app. We do need to look into mTLS support, it's something I'm personally interested in but haven't had time for it yet. Creating a new issue will help track it, yes. Contributions will be welcomed!
@kuolemaaa commented on GitHub (Nov 27, 2024):
yea
partly
So:
This issue, opened in 2019, in this repo, refers to the old C# app.
In 2019, this repo was for the C# app and was called
bitwarden/mobile, now it hosts the kotlin (new, android only) one since v 2024.10.1 (19388) of the 30 Oct 2024.So, in that day, you renamed
mobile->android, created a newmobilerepo and filled with the C# content.If this is correct I would write a statement and completely block any new message in this issue and maybe also in the other issues in this repo referring to the old c# app.
What did you accomplished with such operation? What was the purpose? Just for curiosity
@vvolkgang commented on GitHub (Nov 27, 2024):
Correct. The goal was to keep some of the repo metadata. I'll look into mass locking old issues, thanks for the suggestion!
@scottsavarese commented on GitHub (Nov 27, 2024):
@vvolkgang, I know very little about Android development. But, I'm happy to help in any way. At the very least, I can test versions someone builds against my mTLS setup at home if you need. And if someone wants to spend some time showing me how to build the software I can try to take a stab at coding it. (I mean this isn't the first time someone is doing this. There has to be an example elsewhere to copy from, right?)
@rohm1 commented on GitHub (Nov 27, 2024):
I have started working on it, I've patched the SDK locally and can build everything. I'm able to send requests to my server from the app (built locally, running in the emulator, certificate hardcoded in the SDK), I now need to make some UI to select the certificate, and send it as setting to the SDK. Expect some PRs in the next weeks :)
@scottsavarese commented on GitHub (Nov 27, 2024):
@rohm1 , Awesome. Let me know if I can help test anything.
@superuser866 commented on GitHub (Nov 27, 2024):
@rohm1 this is great news thank you very much.
Hope Bitwarden team will integrate your work as soon as possible as it was a big missing on this app!
@kspearrin
@kuolemaaa commented on GitHub (Nov 27, 2024):
@rohm1 Nice!
I want to point out this comment https://github.com/bitwarden/android/pull/2629#issuecomment-2121008107 about the usage of android system certificate storage in Home Assistant app that works really well
@ippocratis commented on GitHub (Nov 27, 2024):
Why I have the feeling we are going to the same loop again.
Devs have been contributing to this feature request for year and the bitwarden team refused to merge their pull requests for no reason.
What makes you think they will merge them now.
@kuolemaaa commented on GitHub (Nov 27, 2024):
I'm not sure but it I think you are referring to attempts made for the C# version on the app. The point here is keeping in mind the fact that the switch to kotlin was made very recently and possibly there is room for such contibution.
That PR I referred to has the very same history of this issue.
@superuser866 commented on GitHub (Nov 27, 2024):
@ippocratis I hope this time they are going to understand that mTLS support is crucial when exposinge a password manager to the internet as it reduces drammatically the surface of an attack... finger crossed...