github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-15 08:34:16 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3417] [MERGED] Add ability to log non-fatal errors #79447

New Issue
Closed
opened 2026-05-19 17:10:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 17:10:39 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3417
Author: @david-livefront
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/9/2024
Merged by: @david-livefront

Base: main ← Head: non-fatal-error-logging

📝 Commits (1)

  • 43bb4fc Add ability to log non-fatal errors

📊 Changes

3 files changed (+13 additions, -0 deletions)

View changed files

📝 app/src/fdroid/java/com/x8bit/bitwarden/data/platform/manager/CrashLogsManagerImpl.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/CrashLogsManager.kt (+5 -0)
📝 app/src/standard/java/com/x8bit/bitwarden/data/platform/manager/CrashLogsManagerImpl.kt (+6 -0)

📄 Description

🎟️ Tracking

N/A

📔 Objective

Add functionality to allow us to track errors that do not result in a crash. This new functionality respects whether the user has opted out of crashing logging and does not function for FDroid users.

This errors will be displayed in Crashlytics but they will be listed as Non-fatals instead of the Crashes you normally see.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3417 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/9/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `non-fatal-error-logging` --- ### 📝 Commits (1) - [`43bb4fc`](https://github.com/bitwarden/android/commit/43bb4fc387a77f05f56cc8d2ed8c5cc6f8689bf0) Add ability to log non-fatal errors ### 📊 Changes **3 files changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/fdroid/java/com/x8bit/bitwarden/data/platform/manager/CrashLogsManagerImpl.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/CrashLogsManager.kt` (+5 -0) 📝 `app/src/standard/java/com/x8bit/bitwarden/data/platform/manager/CrashLogsManagerImpl.kt` (+6 -0) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective Add functionality to allow us to track errors that do not result in a crash. This new functionality respects whether the user has opted out of crashing logging and does not function for FDroid users. This errors will be displayed in Crashlytics but they will be listed as `Non-fatals` instead of the `Crashes` you normally see. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 17:10:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#79447