github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 17:16:20 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3056] [MERGED] [PM-5731] Fix FIDO2 client bugs #79234

New Issue
Closed
opened 2026-05-19 16:54:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 16:54:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3056
Author: @coroiu
Created: 3/6/2024
Status: ✅ Merged
Merged: 3/6/2024
Merged by: @dinisvieira

Base: feature/maui-migration-passkeys ← Head: fix/fido2-client-bugs

📝 Commits (2)

  • ded86c7 fix: blockedUris null issue
  • c30cfb0 fix: trailing slash in origin breaking check

📊 Changes

3 files changed (+48 additions, -21 deletions)

View changed files

📝 src/Core/Services/Fido2ClientService.cs (+33 -17)
📝 src/Core/Utilities/Fido2/Fido2DomainUtils.cs (+4 -4)
📝 test/Core.Test/Utilities/Fido2/Fido2DomainUtilsTests.cs (+11 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

  • Add null check for blockedUris
  • Fix trailing slash breaking rp/origin check

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3056 **Author:** [@coroiu](https://github.com/coroiu) **Created:** 3/6/2024 **Status:** ✅ Merged **Merged:** 3/6/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `feature/maui-migration-passkeys` ← **Head:** `fix/fido2-client-bugs` --- ### 📝 Commits (2) - [`ded86c7`](https://github.com/bitwarden/android/commit/ded86c7609f349fa9b1e033056ef153aeefdee81) fix: blockedUris null issue - [`c30cfb0`](https://github.com/bitwarden/android/commit/c30cfb041fdedf256869e82755ccda5db573eed4) fix: trailing slash in origin breaking check ### 📊 Changes **3 files changed** (+48 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/Fido2ClientService.cs` (+33 -17) 📝 `src/Core/Utilities/Fido2/Fido2DomainUtils.cs` (+4 -4) 📝 `test/Core.Test/Utilities/Fido2/Fido2DomainUtilsTests.cs` (+11 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective - Add null check for blockedUris - Fix trailing slash breaking rp/origin check ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 16:54:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#79234
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?