github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-17 03:59:18 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2764] [MERGED] [PM-3446] User without MP, item with MP does not show on Android keyboard for autofill #79030

New Issue
Closed
opened 2026-05-19 16:37:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 16:37:50 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2764
Author: @andrebispo5
Created: 9/12/2023
Status: ✅ Merged
Merged: 9/26/2023
Merged by: @andrebispo5

Base: master ← Head: auth/pm-3446/mp-autofill

📝 Commits (2)

  • 2bc4ead [PM-3446] Check if user has mp and allow autofill to use items with mp reprompt
  • 370ec97 [PM-3446] PR fix

📊 Changes

2 files changed (+10 additions, -8 deletions)

View changed files

📝 src/Android/Autofill/AutofillHelpers.cs (+5 -3)
📝 src/Android/Autofill/AutofillService.cs (+5 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Check if user has mp and allow autofill to use items with mp re-prompt.

Code changes

Change method that fetches items to show and bypass mp re-prompt check.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/b1a3dbd1-5d90-4202-a2ac-ac0dd0c924e2

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2764 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/12/2023 **Status:** ✅ Merged **Merged:** 9/26/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `auth/pm-3446/mp-autofill` --- ### 📝 Commits (2) - [`2bc4ead`](https://github.com/bitwarden/android/commit/2bc4ead97c5748c2a0a9421056979d723d0f51b1) [PM-3446] Check if user has mp and allow autofill to use items with mp reprompt - [`370ec97`](https://github.com/bitwarden/android/commit/370ec977a7c21bc2788578ff90991d534bfc3c12) [PM-3446] PR fix ### 📊 Changes **2 files changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/AutofillHelpers.cs` (+5 -3) 📝 `src/Android/Autofill/AutofillService.cs` (+5 -5) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Check if user has mp and allow autofill to use items with mp re-prompt. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Change method that fetches items to show and bypass mp re-prompt check. ## Screenshots https://github.com/bitwarden/mobile/assets/4648522/b1a3dbd1-5d90-4202-a2ac-ac0dd0c924e2 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 16:37:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#79030