github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 21:16:29 -05:00
Code Issues 2.3k Packages Projects Releases 128 Wiki Activity

[PR #1667] [MERGED] only prompt for sso if using key connector #78279

New Issue
Closed
opened 2026-05-19 15:36:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 15:36:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1667
Author: @jlf0dev
Created: 11/29/2021
Status: ✅ Merged
Merged: 11/29/2021
Merged by: @jlf0dev

Base: master ← Head: bug/autofill-sso-prompt

📝 Commits (1)

  • 43d291b only prompt for sso if using key connector

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+6 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Key Connector changes for autofill on iOS were showing the SSO login flow even when a user wasn't a SSO user. This was a logic error, we weren't checking for key connector use while seeing if the user was using biometric without being validated.

Needs to be cherry picked to rc
Asana Task: https://app.asana.com/0/1201363553288890/1201432735007902/f

Code changes

  • src/iOS.Core/Controllers/LockPasswordViewController.cs: Add check for key connector before sso login flow to autofill

Testing requirements

  • iOS autofill with/without key connector & biometric authentication

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1667 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 11/29/2021 **Status:** ✅ Merged **Merged:** 11/29/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/autofill-sso-prompt` --- ### 📝 Commits (1) - [`43d291b`](https://github.com/bitwarden/android/commit/43d291bad0f2d8890b293008cc315377e17214d8) only prompt for sso if using key connector ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+6 -2) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Key Connector changes for autofill on iOS were showing the SSO login flow even when a user wasn't a SSO user. This was a logic error, we weren't checking for key connector use while seeing if the user was using biometric without being validated. Needs to be cherry picked to `rc` Asana Task: https://app.asana.com/0/1201363553288890/1201432735007902/f ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/iOS.Core/Controllers/LockPasswordViewController.cs:** Add check for key connector before sso login flow to autofill ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> - iOS autofill with/without key connector & biometric authentication ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 15:36:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#78279
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?