github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 12:38:11 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1138] [MERGED] [GDPR] Adjusted TOS/Privacy acceptance #78002

New Issue
Closed
opened 2026-05-19 15:15:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 15:15:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1138
Author: @vincentsalucci
Created: 11/4/2020
Status: ✅ Merged
Merged: 11/5/2020
Merged by: @vincentsalucci

Base: master ← Head: m-gdpr

📝 Commits (3)

  • a35c45c GDPR acceptance flows
  • a2ab18c Added specialized margin by platform
  • 0d2ba88 Changed property name

📊 Changes

4 files changed (+99 additions, -1 deletions)

View changed files

📝 src/App/Pages/Accounts/RegisterPage.xaml (+33 -0)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+29 -1)
📝 src/App/Resources/AppResources.Designer.cs (+24 -0)
📝 src/App/Resources/AppResources.resx (+13 -0)

📄 Description

Objective

In order to complete GDPR compliance, moving forward with new user creation, we need to have explicit user interaction for Terms of Service and Privacy Policy acknowledgement.

Code Changes

  • RegisterPage.xaml: Added UI for terms/privacy acknowledgement. Created formatted label text with spannable selectors for each of the policies. Use specialized margin based on platform.
  • RegisterPageViewModel.cs: Added variables for ShowTerms, AcceptPolicies, and created PoliciesClickCommand for opening URIs. Added Submit logic. Added getter property to handle switch margin based on platform.
  • AppResources.resx: Added strings. Note: formatting for the AcceptPolicies string looks weird, but is necessary because of the intentional line break (xml:preserve takes the string as is).

Screenshots

mobile-android-0-base
mobile-android-1-error

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1138 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 11/4/2020 **Status:** ✅ Merged **Merged:** 11/5/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-gdpr` --- ### 📝 Commits (3) - [`a35c45c`](https://github.com/bitwarden/android/commit/a35c45c0931d01d136ff85cfe5385c04a48a9852) GDPR acceptance flows - [`a2ab18c`](https://github.com/bitwarden/android/commit/a2ab18c0fb3c1fd5accf369f46c530c2c16984a8) Added specialized margin by platform - [`0d2ba88`](https://github.com/bitwarden/android/commit/0d2ba88aeac0b10eadd2ae66ef3ed7e3bae420c4) Changed property name ### 📊 Changes **4 files changed** (+99 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+33 -0) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+29 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+24 -0) 📝 `src/App/Resources/AppResources.resx` (+13 -0) </details> ### 📄 Description ## Objective > In order to complete GDPR compliance, moving forward with new user creation, we need to have explicit user interaction for Terms of Service and Privacy Policy acknowledgement. ## Code Changes - **RegisterPage.xaml**: Added UI for terms/privacy acknowledgement. Created formatted label text with spannable selectors for each of the policies. Use specialized margin based on platform. - **RegisterPageViewModel.cs**: Added variables for `ShowTerms`, `AcceptPolicies`, and created `PoliciesClickCommand` for opening URIs. Added `Submit` logic. Added getter property to handle switch margin based on platform. - **AppResources.resx**: Added strings. Note: formatting for the `AcceptPolicies` string looks weird, but is necessary because of the intentional line break (xml:preserve takes the string as is). ## Screenshots ![mobile-android-0-base](https://user-images.githubusercontent.com/26154748/98120010-0510ee00-1e73-11eb-97ed-22685c8091bf.png) ![mobile-android-1-error](https://user-images.githubusercontent.com/26154748/98120015-06421b00-1e73-11eb-8731-6f7a1e5603cc.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 15:15:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#78002
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?