github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6209] [MERGED] [PM-28835] Added validations to prevent duplicate press on buttons #74936

New Issue
Closed
opened 2026-05-17 00:16:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-17 00:16:23 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6209
Author: @aj-rosado
Created: 11/28/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @aj-rosado

Base: main ← Head: PM-28833/save-creates-duplicate-entry

📝 Commits (9)

  • 7afddc3 Added validations to prevent duplicate press on buttons
  • 0de7310 remove unnecessary test
  • dabbbb4 removed unnecessary suppress
  • f841dda Add throttle to button click
  • 5b4ab93 removed isEnabled state check from save buttons
  • a1b01b8 Updated throttleClick method
  • 2ef188e Removed unnecessary state validations on ViewModel
  • ad8a557 remove unnecessary test
  • 94be258 Removed unnecessary breaklines and changed ThrottledClick file name to match the function

📊 Changes

4 files changed (+44 additions, -3 deletions)

View changed files

📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenFilledButton.kt (+2 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenOutlinedButton.kt (+2 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenTextButton.kt (+2 -1)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/components/util/ThrottledClick.kt (+38 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28835

📔 Objective

On some scenarios if the user tried to multi press the button he can create multiple entries by mistake. This address that issue on item, folder and send creation and also fixes multiple calls to remove password.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6209 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-28833/save-creates-duplicate-entry` --- ### 📝 Commits (9) - [`7afddc3`](https://github.com/bitwarden/android/commit/7afddc3c1631f2deb8295e3efd7189b745d1c8fa) Added validations to prevent duplicate press on buttons - [`0de7310`](https://github.com/bitwarden/android/commit/0de731040e14cbd3202ec70cb25f86b8a117bb08) remove unnecessary test - [`dabbbb4`](https://github.com/bitwarden/android/commit/dabbbb4c2023448414fc3bf7924756930f28d49a) removed unnecessary suppress - [`f841dda`](https://github.com/bitwarden/android/commit/f841dda6501524042a1bfddda7b9a015d13ad136) Add throttle to button click - [`5b4ab93`](https://github.com/bitwarden/android/commit/5b4ab93b4d5b1ab27ea0ec0cf0cb48ad9cdb8c82) removed isEnabled state check from save buttons - [`a1b01b8`](https://github.com/bitwarden/android/commit/a1b01b8673bbdc852ef0b9e44a6cb5fc285f019b) Updated throttleClick method - [`2ef188e`](https://github.com/bitwarden/android/commit/2ef188e27be47182f7f41d2809c7c9741d9e9bef) Removed unnecessary state validations on ViewModel - [`ad8a557`](https://github.com/bitwarden/android/commit/ad8a557c0093148000707f9ad864473764880d5a) remove unnecessary test - [`94be258`](https://github.com/bitwarden/android/commit/94be2583968ea0f1782c87216db61b04cf9b616f) Removed unnecessary breaklines and changed ThrottledClick file name to match the function ### 📊 Changes **4 files changed** (+44 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenFilledButton.kt` (+2 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenOutlinedButton.kt` (+2 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenTextButton.kt` (+2 -1) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/components/util/ThrottledClick.kt` (+38 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-28835 ## 📔 Objective On some scenarios if the user tried to multi press the button he can create multiple entries by mistake. This address that issue on item, folder and send creation and also fixes multiple calls to remove password. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-17 00:16:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#74936