[PR #3191] [MERGED] [PM-7576] Implemented digital asset links verification on Fido2 flows #72614

Closed
opened 2026-05-16 21:36:56 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3191
Author: @fedemkr
Created: 4/25/2024
Status: ✅ Merged
Merged: 4/25/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7576/verify-native-apps-dal


📝 Commits (6)

  • aaa45b1 PM-7553 Fix native apps passkeys autofill and creation
  • 24ed46b PM-7658 Implemented Fido2 priviliged apps verification
  • a9e6264 PM-7576 Implemented digital asset links verification on Fido2 flows for native apps.
  • 5d8d249 Merge branch 'feature/maui-migration-passkeys' into mobiletf/pm-7576/verify-native-apps-dal
  • c198664 PM-7576 Renamed to ValidateAssetLinksAndGetOriginAsync to go along with Google naming and also changed method to private given that public is not necessary
  • f54ec36 PM-7576 Moved digital asset links verification to a Core service AssetLinksService and added unit tests for it.

📊 Changes

13 files changed (+598 additions, -49 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+14 -5)
📝 src/App/Platforms/Android/Utilities/CallingAppInfoExtensions.cs (+14 -0)
📝 src/Core/Abstractions/IApiService.cs (+2 -6)
➕ src/Core/Abstractions/IAssetLinksService.cs (+7 -0)
📝 src/Core/Services/ApiService.cs (+27 -0)
➕ src/Core/Services/AssetLinksService.cs (+35 -0)
➕ src/Core/Utilities/DigitalAssetLinks/Statement.cs (+8 -0)
➕ src/Core/Utilities/DigitalAssetLinks/Target.cs (+14 -0)
📝 src/Core/Utilities/ServiceContainer.cs (+3 -0)
➕ test/Core.Test/Services/AssetLinksServiceTest.cs (+165 -0)
➕ test/Core.Test/Services/AssetLinksServiceTestData/BasicAssetLinksTestData.cs (+179 -0)
📝 test/Core.Test/Services/Fido2ClientAssertCredentialTests.cs (+52 -12)
📝 test/Core.Test/Services/Fido2ClientCreateCredentialTests.cs (+78 -26)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Verify Digital asset links on Fido2 flows for non-privileged native Android apps.

Code changes

  • CredentialHelpers: Implemented digital asset links verification.
  • ApiService: Added call to get the digital asset links and transform them into a list of statement objects.
  • CallingAppInfoExtensions: Added call to get the latest normalized certificate fingerprint to compare it with the statement targets.
  • Tests: Fixed failing unit tests

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3191 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/25/2024 **Status:** ✅ Merged **Merged:** 4/25/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7576/verify-native-apps-dal` --- ### 📝 Commits (6) - [`aaa45b1`](https://github.com/bitwarden/android/commit/aaa45b18a4551d8092019a03fe3b3d26af35538d) PM-7553 Fix native apps passkeys autofill and creation - [`24ed46b`](https://github.com/bitwarden/android/commit/24ed46b530174c3f8363e50b5d8a9f04d3134433) PM-7658 Implemented Fido2 priviliged apps verification - [`a9e6264`](https://github.com/bitwarden/android/commit/a9e6264e31f5ed2820ccfb93ff5c16b27bacb3e2) PM-7576 Implemented digital asset links verification on Fido2 flows for native apps. - [`5d8d249`](https://github.com/bitwarden/android/commit/5d8d24977b747731d9b86c36667077f99a7cbab3) Merge branch 'feature/maui-migration-passkeys' into mobiletf/pm-7576/verify-native-apps-dal - [`c198664`](https://github.com/bitwarden/android/commit/c198664374b208151432084be3294ade2cd5c6b8) PM-7576 Renamed to ValidateAssetLinksAndGetOriginAsync to go along with Google naming and also changed method to private given that public is not necessary - [`f54ec36`](https://github.com/bitwarden/android/commit/f54ec36c22097b3a1d2ef4a3fb2c6cacba67a2e0) PM-7576 Moved digital asset links verification to a Core service AssetLinksService and added unit tests for it. ### 📊 Changes **13 files changed** (+598 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+14 -5) 📝 `src/App/Platforms/Android/Utilities/CallingAppInfoExtensions.cs` (+14 -0) 📝 `src/Core/Abstractions/IApiService.cs` (+2 -6) ➕ `src/Core/Abstractions/IAssetLinksService.cs` (+7 -0) 📝 `src/Core/Services/ApiService.cs` (+27 -0) ➕ `src/Core/Services/AssetLinksService.cs` (+35 -0) ➕ `src/Core/Utilities/DigitalAssetLinks/Statement.cs` (+8 -0) ➕ `src/Core/Utilities/DigitalAssetLinks/Target.cs` (+14 -0) 📝 `src/Core/Utilities/ServiceContainer.cs` (+3 -0) ➕ `test/Core.Test/Services/AssetLinksServiceTest.cs` (+165 -0) ➕ `test/Core.Test/Services/AssetLinksServiceTestData/BasicAssetLinksTestData.cs` (+179 -0) 📝 `test/Core.Test/Services/Fido2ClientAssertCredentialTests.cs` (+52 -12) 📝 `test/Core.Test/Services/Fido2ClientCreateCredentialTests.cs` (+78 -26) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Verify Digital asset links on Fido2 flows for non-privileged native Android apps. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CredentialHelpers:** Implemented digital asset links verification. * **ApiService:** Added call to get the digital asset links and transform them into a list of statement objects. * **CallingAppInfoExtensions:** Added call to get the latest normalized certificate fingerprint to compare it with the statement targets. * **Tests:** Fixed failing unit tests ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 21:36:56 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#72614