github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3026] [MERGED] [PM-6301] Fix for pending login view breaks after closing one request #72503

New Issue
Closed
opened 2026-05-16 21:27:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 21:27:49 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3026
Author: @dinisvieira
Created: 2/23/2024
Status: ✅ Merged
Merged: 2/26/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-6301-pending-login-close-request-fix

📝 Commits (1)

  • a145e0c PM-6301 Removed IsRefreshing=true in RefreshAsync as it can trigger the RefreshView to trigger the RefreshView command again

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 src/Core/Pages/Settings/LoginPasswordlessRequestsListViewModel.cs (+0 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Currently on iOS there are still Layout issues related with the RefreshView.
These seem to be caused by the IsRefreshing being set to true on RefreshAsync which the RefreshView seems to use to trigger the RefreshCommand again. This duplicate execution causes layout issues on iOS.

Code changes

Removing IsRefreshing=true fixes the issue. The only worry is that the busy indicator would not appear, but this doesn't seem to be a problem because when doing PullToRefresh the RefreshView changes IsRefreshing and shows the indicator.
For the other situations where we execute RefreshAsync the LoginPasswordlessRequestsListPage.xaml.cs takes care of the busy indicator.

  • LoginPasswordlessRequestsListViewModel.cs: Removed IsRefreshing=true

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3026 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/23/2024 **Status:** ✅ Merged **Merged:** 2/26/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-6301-pending-login-close-request-fix` --- ### 📝 Commits (1) - [`a145e0c`](https://github.com/bitwarden/android/commit/a145e0ce711a92f3f557925f4211176d93c3074e) PM-6301 Removed IsRefreshing=true in RefreshAsync as it can trigger the RefreshView to trigger the RefreshView command again ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Settings/LoginPasswordlessRequestsListViewModel.cs` (+0 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Currently on iOS there are still Layout issues related with the RefreshView. These seem to be caused by the IsRefreshing being set to true on RefreshAsync which the RefreshView seems to use to trigger the RefreshCommand again. This duplicate execution causes layout issues on iOS. ## Code changes Removing `IsRefreshing=true` fixes the issue. The only worry is that the busy indicator would not appear, but this doesn't seem to be a problem because when doing PullToRefresh the RefreshView changes IsRefreshing and shows the indicator. For the other situations where we execute RefreshAsync the `LoginPasswordlessRequestsListPage.xaml.cs` takes care of the busy indicator. * **LoginPasswordlessRequestsListViewModel.cs:** Removed `IsRefreshing=true` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 21:27:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#72503