github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 13:07:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2670] [MERGED] [PM-2289] Change header title based on auth request type #72253

New Issue
Closed
opened 2026-05-16 21:09:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 21:09:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2670
Author: @andrebispo5
Created: 8/7/2023
Status: ✅ Merged
Merged: 8/8/2023
Merged by: @andrebispo5

Base: feature/pm-1029-tde-login ← Head: auth/pm-2289-title-fix

📝 Commits (3)

  • cc9070e [PM-2289] Change header title based on auth request type
  • a0bd3dc [PM-2289] PR fix
  • c2f3585 Merge branch 'feature/pm-1029-tde-login' into auth/pm-2289-title-fix

📊 Changes

4 files changed (+43 additions, -13 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPasswordlessRequestPage.xaml (+2 -2)
📝 src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs (+29 -11)
📝 src/App/Resources/AppResources.Designer.cs (+9 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Change header title based on auth request type.

Code changes

PageTitle is set after AuthRequestType so the label changes accordingly.

Screenshots

image image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2670 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/7/2023 **Status:** ✅ Merged **Merged:** 8/8/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/pm-1029-tde-login` ← **Head:** `auth/pm-2289-title-fix` --- ### 📝 Commits (3) - [`cc9070e`](https://github.com/bitwarden/android/commit/cc9070ec51da6c3300314450ff8bd8a354e146a1) [PM-2289] Change header title based on auth request type - [`a0bd3dc`](https://github.com/bitwarden/android/commit/a0bd3dc199886163661dddfbfb1029a91dc4b13f) [PM-2289] PR fix - [`c2f3585`](https://github.com/bitwarden/android/commit/c2f35859f0146da2f425b9292ba5fbcbc42919f5) Merge branch 'feature/pm-1029-tde-login' into auth/pm-2289-title-fix ### 📊 Changes **4 files changed** (+43 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPasswordlessRequestPage.xaml` (+2 -2) 📝 `src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs` (+29 -11) 📝 `src/App/Resources/AppResources.Designer.cs` (+9 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Change header title based on auth request type. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> PageTitle is set after AuthRequestType so the label changes accordingly. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="440" alt="image" src="https://github.com/bitwarden/mobile/assets/4648522/c5e478f0-523d-4772-b919-6df958b85c8e"> <img width="450" alt="image" src="https://github.com/bitwarden/mobile/assets/4648522/0e4dd3bc-6c95-49a2-89d0-88b01bba2b8a"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 21:09:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#72253