github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 21:16:29 -05:00
Code Issues 2.3k Packages Projects Releases 128 Wiki Activity

[PR #4653] [MERGED] PM-16861 - Update Behavior When Tapping Same Generator Tab Already Viewing #69056

New Issue
Closed
opened 2026-05-14 11:33:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 11:33:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4653
Author: @phil-livefront
Created: 1/30/2025
Status: ✅ Merged
Merged: 1/31/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-16861-Update-Behavior-When-Tapping-Same-Generator-Tab-Already-Viewing

📝 Commits (4)

  • 9b7c357 PM-16861 - Prevent tapping the same segment control from updating data
  • 8ed502f adding test
  • 52bef92 fix lint issues
  • 3bd2f39 fix more lint issues

📊 Changes

2 files changed (+33 additions, -2 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt (+31 -2)

📄 Description

🎟️ Tracking

PM-16861

📔 Objective

  • When tapping on the same segmented button selection (Password / Passphrase / Username) a new password/passphrase/username is not generated again. User can tap the same tab over and over and nothing should change.

📸 Screenshots

untitled.webm

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4653 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-16861-Update-Behavior-When-Tapping-Same-Generator-Tab-Already-Viewing` --- ### 📝 Commits (4) - [`9b7c357`](https://github.com/bitwarden/android/commit/9b7c357c374c3e85989ba7ee5843806cfcc48ec6) PM-16861 - Prevent tapping the same segment control from updating data - [`8ed502f`](https://github.com/bitwarden/android/commit/8ed502f66e23e747b633ec3f1069e69772de1ceb) adding test - [`52bef92`](https://github.com/bitwarden/android/commit/52bef9202b82dfa43819cc6cd3bf96c52d7ea2e2) fix lint issues - [`3bd2f39`](https://github.com/bitwarden/android/commit/3bd2f3961aa2a746296ba9e7c5d9e0907d10c99f) fix more lint issues ### 📊 Changes **2 files changed** (+33 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt` (+31 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-16861](https://bitwarden.atlassian.net/browse/PM-16861) ## 📔 Objective - When tapping on the same segmented button selection (Password / Passphrase / Username) a new password/passphrase/username is not generated again. User can tap the same tab over and over and nothing should change. ## 📸 Screenshots [untitled.webm](https://github.com/user-attachments/assets/7c724933-8612-4bf3-892f-909f409e6795) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-16861]: https://bitwarden.atlassian.net/browse/PM-16861?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 11:33:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#69056
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?