github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[GH-ISSUE #615] Bitwarden default theme should change from dark to light on the fly #6864

New Issue
Closed
opened 2026-04-10 23:13:24 -05:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-04-10 23:13:24 -05:00
Owner
Copy Link

Originally created by @Crocmagnon on GitHub (Oct 2, 2019).
Original GitHub issue: https://github.com/bitwarden/android/issues/615

Originally assigned to: @mpbw2 on GitHub.

Other iOS apps change their theme on the fly when the user changes the system wide theme but Bitwarden requires a full restart.
When the default theme is selected, the color palette should change from light to dark on the fly without requiring any other action from the user.

This page from Apple’s developer docs says this:

When the user toggles between light and dark interfaces, the system asks your app to redraw all of its content.

So we should be able to detect the change and act when it happens.

Originally created by @Crocmagnon on GitHub (Oct 2, 2019). Original GitHub issue: https://github.com/bitwarden/android/issues/615 Originally assigned to: @mpbw2 on GitHub. Other iOS apps change their theme on the fly when the user changes the system wide theme but Bitwarden requires a full restart. When the default theme is selected, the color palette should change from light to dark on the fly without requiring any other action from the user. [This page](https://developer.apple.com/documentation/appkit/supporting_dark_mode_in_your_interface) from Apple’s developer docs says this: > When the user toggles between light and dark interfaces, the system asks your app to redraw all of its content. So we should be able to detect the change and act when it happens.
GiteaMirror commented 2026-04-10 23:13:26 -05:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 5, 2020):

I have Premium. Could you just make the app respect system-wide night mode setting?
The phone is set to dark, yet Other > Options > Theme only has light.
Using Nougat.

<!-- gh-comment-id:739233354 --> @ghost commented on GitHub (Dec 5, 2020): I have Premium. Could you just make the app respect system-wide night mode setting? The phone is set to dark, yet Other > Options > Theme only has light. Using Nougat.
GiteaMirror commented 2026-04-10 23:13:26 -05:00
Author
Owner
Copy Link

@proletarius101 commented on GitHub (Jan 18, 2021):

Not hard to do so: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/theming/system-theme-changes

<!-- gh-comment-id:762393829 --> @proletarius101 commented on GitHub (Jan 18, 2021): Not hard to do so: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/theming/system-theme-changes
GiteaMirror commented 2026-04-10 23:13:27 -05:00
Author
Owner
Copy Link

@tgreer-bw commented on GitHub (Jan 19, 2021):

If you set the theme as 'default' it should respond to system settings.

<!-- gh-comment-id:762889868 --> @tgreer-bw commented on GitHub (Jan 19, 2021): If you set the theme as 'default' it should respond to system settings.
GiteaMirror commented 2026-04-10 23:13:28 -05:00
Author
Owner
Copy Link

@Crocmagnon commented on GitHub (Jan 19, 2021):

It doesn’t respect a toggle between dark and light mode when the app is running, which is problematic.

Steps to reproduce:

Switch iOS to light mode
Open the app
Switch to dark mode while the app is running (foreground or background), with the control center for example
Return to the app
It’s still light when it should have changed to dark.

--
Gabriel Augendre
Sent from a mobile device / Envoyé depuis un appareil mobile

Le 19 janv. 2021 à 15:50, Trey Greer notifications@github.com a écrit :


If you set the theme as 'default' it should respond to system settings.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<!-- gh-comment-id:762947207 --> @Crocmagnon commented on GitHub (Jan 19, 2021): It doesn’t respect a toggle between dark and light mode when the app is running, which is problematic. Steps to reproduce: Switch iOS to light mode Open the app Switch to dark mode while the app is running (foreground or background), with the control center for example Return to the app It’s still light when it should have changed to dark. -- Gabriel Augendre Sent from a mobile device / Envoyé depuis un appareil mobile > Le 19 janv. 2021 à 15:50, Trey Greer <notifications@github.com> a écrit : > >  > If you set the theme as 'default' it should respond to system settings. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or unsubscribe.
GiteaMirror commented 2026-04-10 23:13:28 -05:00
Author
Owner
Copy Link

@tgreer-bw commented on GitHub (Jan 19, 2021):

Ah - yes, this is actively being worked on with other theming updates. Stay tuned.

<!-- gh-comment-id:762948598 --> @tgreer-bw commented on GitHub (Jan 19, 2021): Ah - yes, this is actively being worked on with other theming updates. Stay tuned.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6864
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?