github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4047] [MERGED] [PM-12695] Add hidden field changes to password history #68594

New Issue
Closed
opened 2026-05-14 10:56:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 10:56:38 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4047
Author: @andrebispo5
Created: 10/8/2024
Status: ✅ Merged
Merged: 10/8/2024
Merged by: @andrebispo5

Base: main ← Head: pm-12693/hidden-fields-history

📝 Commits (5)

  • 0821b90 PM-12693 Add hidden field updates to password history
  • 0c0cfa6 PM-12693 Update tests to support adding hidden field updates to password history
  • e49890e PM-12693 Update PR with suggestions
  • b69363d Merge branch 'main' into pm-12693/hidden-fields-history
  • 053e9c7 Merge branch 'main' into pm-12693/hidden-fields-history

📊 Changes

2 files changed (+90 additions, -15 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+64 -13)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt (+26 -2)

📄 Description

🎟️ Tracking

PM-12693

📔 Objective

When an hidden field is updated, the changes should reflect in the password history list.

📸 Screenshots

https://github.com/user-attachments/assets/22b3d35b-4ddb-4887-872f-7d670fb510db

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4047 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/8/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-12693/hidden-fields-history` --- ### 📝 Commits (5) - [`0821b90`](https://github.com/bitwarden/android/commit/0821b90e58e1a9c4a9b004f4a38beb4cc3d399f2) [PM-12693] Add hidden field updates to password history - [`0c0cfa6`](https://github.com/bitwarden/android/commit/0c0cfa645b85e1154566a9f2471ec922930a161d) [PM-12693] Update tests to support adding hidden field updates to password history - [`e49890e`](https://github.com/bitwarden/android/commit/e49890ef8e9607993c19ec044afb6512328c3d33) [PM-12693] Update PR with suggestions - [`b69363d`](https://github.com/bitwarden/android/commit/b69363dd648273aaa20d8811e2d1a9e52d9b5e05) Merge branch 'main' into pm-12693/hidden-fields-history - [`053e9c7`](https://github.com/bitwarden/android/commit/053e9c7c9e108f9f3bb29cea3ad8918aafc958bc) Merge branch 'main' into pm-12693/hidden-fields-history ### 📊 Changes **2 files changed** (+90 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+64 -13) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt` (+26 -2) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> [PM-12693](https://bitwarden.atlassian.net/browse/PM-12693) ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> When an hidden field is updated, the changes should reflect in the password history list. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> https://github.com/user-attachments/assets/22b3d35b-4ddb-4887-872f-7d670fb510db ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-12693]: https://bitwarden.atlassian.net/browse/PM-12693?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 10:56:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#68594