github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[GH-ISSUE #584] Slight issue on Portuguese Translation #6837

New Issue
Closed
opened 2026-04-10 23:11:20 -05:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-04-10 23:11:20 -05:00
Owner
Copy Link

Originally created by @andre-paulo98 on GitHub (Aug 22, 2019).
Original GitHub issue: https://github.com/bitwarden/android/issues/584

Every word in Portuguese has a gender, either female/male.
When a password is copied, the toast says: "Palavra-passe foi copiado".
And on AppResources.pt-PT.resx it has:

  <data name="ValueHasBeenCopied" xml:space="preserve">
    <value>{0} foi copiado.</value>
    <comment>Confirmation message after suceessfully copying a value to the clipboard.</comment>
  </data>

This is not right. "Palavra-passe" in Portuguese is "female" so it should be instead "Palavra-passe foi copiada" (difference is the last letter)

Now you can't change ValueHasBeenCopied to the "female" version because that would break other strings.
From what I could tell from the usage of that string, only the Password needs to be changed.

Originally created by @andre-paulo98 on GitHub (Aug 22, 2019). Original GitHub issue: https://github.com/bitwarden/android/issues/584 Every word in Portuguese has a gender, either female/male. When a password is copied, the toast says: "_Palavra-passe foi copiado_". And on AppResources.pt-PT.resx it has: ``` <data name="ValueHasBeenCopied" xml:space="preserve"> <value>{0} foi copiado.</value> <comment>Confirmation message after suceessfully copying a value to the clipboard.</comment> </data> ``` This is not right. "Palavra-passe" in Portuguese is "female" so it should be instead "_Palavra-passe foi copiada_" (difference is the last letter) Now you can't change ValueHasBeenCopied to the "female" version because that would break other strings. From what I could tell from the usage of that string, only the Password needs to be changed.
GiteaMirror commented 2026-04-10 23:11:22 -05:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Aug 22, 2019):

Hi,
Please see the following for contributing to translations. Thanks!

https://github.com/bitwarden/mobile/blob/master/CONTRIBUTING.md

<!-- gh-comment-id:523874115 --> @kspearrin commented on GitHub (Aug 22, 2019): Hi, Please see the following for contributing to translations. Thanks! https://github.com/bitwarden/mobile/blob/master/CONTRIBUTING.md
GiteaMirror commented 2026-04-10 23:11:22 -05:00
Author
Owner
Copy Link

@andre-paulo98 commented on GitHub (Aug 22, 2019):

This issue can't be fixed just by changing the one line on Crowdin because it's depending on one specific word.

<!-- gh-comment-id:523891704 --> @andre-paulo98 commented on GitHub (Aug 22, 2019): This issue can't be fixed just by changing the one line on Crowdin because it's depending on one specific word.
GiteaMirror commented 2026-04-10 23:11:22 -05:00
Author
Owner
Copy Link

@Crocmagnon commented on GitHub (Aug 22, 2019):

I guess this issue is not relevant to Crowdin and maybe should be reopened. As stated, you can't change all ValueHasBeenCopied because in various languages (Portuguese and French being two examples) the translation would vary depending on the {0} parameter.

Or, another solution would be to use something more invariant, like {0} foi copiado/a. Would that seem acceptable @andre-paulo98 ? If yes, please suggest the modification on Crowdin 🙂

<!-- gh-comment-id:523891907 --> @Crocmagnon commented on GitHub (Aug 22, 2019): I guess this issue is not relevant to Crowdin and maybe should be reopened. As stated, you can't change all `ValueHasBeenCopied` because in various languages (Portuguese and French being two examples) the translation would vary depending on the `{0}` parameter. Or, another solution would be to use something more invariant, like `{0} foi copiado/a`. Would that seem acceptable @andre-paulo98 ? If yes, please suggest the modification on Crowdin 🙂
GiteaMirror commented 2026-04-10 23:11:23 -05:00
Author
Owner
Copy Link

@andre-paulo98 commented on GitHub (Aug 23, 2019):

I guess that could work yes, while not perfect.
I'll make an account on Crowdin and suggest it.

<!-- gh-comment-id:524416880 --> @andre-paulo98 commented on GitHub (Aug 23, 2019): I guess that could work yes, while not perfect. I'll make an account on Crowdin and suggest it.
GiteaMirror commented 2026-04-10 23:11:23 -05:00
Author
Owner
Copy Link

@Crocmagnon commented on GitHub (Aug 26, 2019):

I applied a similar fix in French, thanks for bringing this to our attention 🙂

<!-- gh-comment-id:524744281 --> @Crocmagnon commented on GitHub (Aug 26, 2019): I applied a similar fix in French, thanks for bringing this to our attention 🙂
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6837
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?