github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[GH-ISSUE #564] App crashes on password save when VPN is not established #6827

New Issue
Closed
opened 2026-04-10 23:09:46 -05:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-04-10 23:09:46 -05:00
Owner
Copy Link

Originally created by @davidplrobinson on GitHub (Jul 22, 2019).
Original GitHub issue: https://github.com/bitwarden/android/issues/564

If you use a VPN to connect to your bitwarden server from iOS app, when updating a password, the app crashes if the VPN connection is not established when you press 'save'.

Should either cache the updates until a connection is established and a successful sync is performed, or at a minimum produce a connection error to allow user to connect to VPN and retry.

Originally created by @davidplrobinson on GitHub (Jul 22, 2019). Original GitHub issue: https://github.com/bitwarden/android/issues/564 If you use a VPN to connect to your bitwarden server from iOS app, when updating a password, the app crashes if the VPN connection is not established when you press 'save'. Should either cache the updates until a connection is established and a successful sync is performed, or at a minimum produce a connection error to allow user to connect to VPN and retry.
GiteaMirror commented 2026-04-10 23:09:47 -05:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Jul 22, 2019):

when updating a password

Is this just editing an item and saving from the main app?

<!-- gh-comment-id:513735508 --> @kspearrin commented on GitHub (Jul 22, 2019): > when updating a password Is this just editing an item and saving from the main app?
GiteaMirror commented 2026-04-10 23:09:47 -05:00
Author
Owner
Copy Link

@davidplrobinson commented on GitHub (Jul 22, 2019):

Yes, so if a secret already exists in the app, and you update the password while the VPN is not connected, the app crashes.

See attached dropbox link for video showing the issue -

https://www.dropbox.com/s/fy015yg5ej0z6rq/RPReplay_Final1563795936.MP4?dl=0

<!-- gh-comment-id:513765647 --> @davidplrobinson commented on GitHub (Jul 22, 2019): Yes, so if a secret already exists in the app, and you update the password while the VPN is not connected, the app crashes. See attached dropbox link for video showing the issue - https://www.dropbox.com/s/fy015yg5ej0z6rq/RPReplay_Final1563795936.MP4?dl=0
GiteaMirror commented 2026-04-10 23:09:48 -05:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Jul 23, 2019):

I would think a connection error alert would be produced here since we attempt to account for that. What is the timestamp for that crash in your video? I see 21:45. What time zone is that?

<!-- gh-comment-id:514042359 --> @kspearrin commented on GitHub (Jul 23, 2019): I would think a connection error alert would be produced here since we attempt to account for that. What is the timestamp for that crash in your video? I see 21:45. What time zone is that?
GiteaMirror commented 2026-04-10 23:09:48 -05:00
Author
Owner
Copy Link

@davidplrobinson commented on GitHub (Jul 23, 2019):

Timezone is Melbourne Australia (GMT+10).

<!-- gh-comment-id:514111542 --> @davidplrobinson commented on GitHub (Jul 23, 2019): Timezone is Melbourne Australia (GMT+10).
GiteaMirror commented 2026-04-10 23:09:49 -05:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Jul 23, 2019):

Can you share what kind of device and iOS version you are using?

<!-- gh-comment-id:514181766 --> @kspearrin commented on GitHub (Jul 23, 2019): Can you share what kind of device and iOS version you are using?
GiteaMirror commented 2026-04-10 23:09:49 -05:00
Author
Owner
Copy Link

@davidplrobinson commented on GitHub (Jul 23, 2019):

Hi, sure... I'm using iPhoneX running on iOS 12.4 - this was upgraded today from 12.3.2 and I can confirm the issue can still be replicated on this new version.

<!-- gh-comment-id:514188286 --> @davidplrobinson commented on GitHub (Jul 23, 2019): Hi, sure... I'm using iPhoneX running on iOS 12.4 - this was upgraded today from 12.3.2 and I can confirm the issue can still be replicated on this new version.
GiteaMirror commented 2026-04-10 23:09:49 -05:00
Author
Owner
Copy Link

@vvolkgang commented on GitHub (Jun 20, 2024):

Issue migrated to https://github.com/bitwarden/mobile/issues/564

<!-- gh-comment-id:2181552080 --> @vvolkgang commented on GitHub (Jun 20, 2024): Issue migrated to https://github.com/bitwarden/mobile/issues/564
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6827
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?