github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-21 17:00:11 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3630] [MERGED] [PM-9409] Authenticate selected FIDO 2 credential #68253

New Issue
Closed
opened 2026-05-14 10:29:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 10:29:40 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3630
Author: @SaintPatrck
Created: 7/25/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-9409/perform-assertion

📝 Commits (7)

  • 0403b05 [PM-9409] Authenticate selected FIDO 2 credential
  • 1a57a00 Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9409/perform-assertion
  • 0bddbd4 Increase coverage
  • 9ebffa2 Rename fido 2 error event
  • d95e49b More coverage
  • feb5a74 Detekt
  • 2bd8571 Fix failing test

📊 Changes

9 files changed (+950 additions, -127 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt (+29 -14)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+6 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+215 -29)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt (+32 -24)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialViewUtil.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/PasskeyAssertionOptionsTestHelpers.kt (+3 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+36 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+599 -27)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt (+29 -29)

📄 Description

🎟️ Tracking

PM-9409

📔 Objective

Perform FIDO 2 public key credential authentication with the Passkey selected on the system bottomsheet and notify the relying party of the result.

📸 Screenshots

passkey-assertion-unlocked

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3630 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/25/2024 **Status:** ✅ Merged **Merged:** 7/26/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-9409/perform-assertion` --- ### 📝 Commits (7) - [`0403b05`](https://github.com/bitwarden/android/commit/0403b0537d08e51c4f3aa89b2f272c68899d1285) [PM-9409] Authenticate selected FIDO 2 credential - [`1a57a00`](https://github.com/bitwarden/android/commit/1a57a005ed4f112c96cb3a8084898229bfe0d6d2) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9409/perform-assertion - [`0bddbd4`](https://github.com/bitwarden/android/commit/0bddbd4acdc6b677a4a1ecf64fd4a5de9844a310) Increase coverage - [`9ebffa2`](https://github.com/bitwarden/android/commit/9ebffa2d4502e7add2ef1e01c3d34011b17e7c9d) Rename fido 2 error event - [`d95e49b`](https://github.com/bitwarden/android/commit/d95e49be766ad19fcbbe55d745fc3aa70ded8662) More coverage - [`feb5a74`](https://github.com/bitwarden/android/commit/feb5a7457a6708574f5d3340446fe72f2ff379fb) Detekt - [`2bd8571`](https://github.com/bitwarden/android/commit/2bd8571f26168e9a6d6d968a5706f8b15f8a8151) Fix failing test ### 📊 Changes **9 files changed** (+950 additions, -127 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt` (+29 -14) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+6 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+215 -29) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt` (+32 -24) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialViewUtil.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/PasskeyAssertionOptionsTestHelpers.kt` (+3 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+36 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+599 -27) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt` (+29 -29) </details> ### 📄 Description ## 🎟️ Tracking PM-9409 ## 📔 Objective Perform FIDO 2 public key credential authentication with the Passkey selected on the system bottomsheet and notify the relying party of the result. ## 📸 Screenshots ![passkey-assertion-unlocked](https://github.com/user-attachments/assets/74396eb1-10a5-4c9d-b9e4-35161105e2ed) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 10:29:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#68253