github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-30 17:33:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3208] [MERGED] [PM-7698] Fix crash produced for non-catched exception on iOS Autofill #68045

New Issue
Closed
opened 2026-05-14 10:15:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 10:15:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3208
Author: @fedemkr
Created: 5/1/2024
Status: ✅ Merged
Merged: 5/1/2024
Merged by: @fedemkr

Base: main ← Head: mobiletf/pm-7698/autofill-crash-on-combined-view

📝 Commits (1)

  • a88183f PM-7698 Fix crash because the catch logic was wrong and it was allowing certain exception to bubble up and explode, so move the if internally.

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 src/Core/Utilities/TaskExtensions.cs (+5 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix crash produced for non-catched exception on iOS Autofill when opening the combined Password + Passkeys view with no Passkeys to load.

Code changes

  • TaskExtensions: Moved shouldLogException to an internal if so all exceptions are catched and then the specific ones logged which was the original intent.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3208 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 5/1/2024 **Status:** ✅ Merged **Merged:** 5/1/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `main` ← **Head:** `mobiletf/pm-7698/autofill-crash-on-combined-view` --- ### 📝 Commits (1) - [`a88183f`](https://github.com/bitwarden/android/commit/a88183f2257b9b4a2cb8f8e6afe6ca96b41f6da3) PM-7698 Fix crash because the catch logic was wrong and it was allowing certain exception to bubble up and explode, so move the if internally. ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Utilities/TaskExtensions.cs` (+5 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix crash produced for non-catched exception on iOS Autofill when opening the combined Password + Passkeys view with no Passkeys to load. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **TaskExtensions:** Moved `shouldLogException` to an internal `if` so all exceptions are catched and then the specific ones logged which was the original intent. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 10:15:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#68045