github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-12 22:51:28 -05:00
Code Issues 2.3k Packages Projects Releases 128 Wiki Activity

[PR #2989] [MERGED] [PM-5900] Fix for Device Login push notifications cause the app to show HomePage #67891

New Issue
Closed
opened 2026-05-14 10:05:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 10:05:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2989
Author: @dinisvieira
Created: 2/9/2024
Status: ✅ Merged
Merged: 2/13/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-5900-fix-for-opening-app-from-notification

📝 Commits (3)

  • c735a5c PM-5900 Fix for Device Login push notifications cause the app to show the HomePage
  • ba8d990 PM-5900 Added edge case scenario if intent / packageName / packageManager is null
  • 5b299fd Merge branch 'main' into feature/PM-5900-fix-for-opening-app-from-notification

📊 Changes

1 file changed (+17 additions, -12 deletions)

View changed files

📝 src/App/Platforms/Android/Services/AndroidPushNotificationService.cs (+17 -12)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix for Device Login push notifications causing the app to show HomePage.
MAUI is treating the Intent on the push notification as a triggering the creation of a new Activity and we just want to open the existing one.

Code changes

  • AndroidPushNotificationService.cs: Changed the Intent when tapping the push notification to launch the existing activity instead of creating a new one.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2989 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/9/2024 **Status:** ✅ Merged **Merged:** 2/13/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-5900-fix-for-opening-app-from-notification` --- ### 📝 Commits (3) - [`c735a5c`](https://github.com/bitwarden/android/commit/c735a5cdd657fd88271da869314afc7be9d635c4) PM-5900 Fix for Device Login push notifications cause the app to show the HomePage - [`ba8d990`](https://github.com/bitwarden/android/commit/ba8d9908fcaf37e1af0a3fd50d39b097882f70e7) PM-5900 Added edge case scenario if intent / packageName / packageManager is null - [`5b299fd`](https://github.com/bitwarden/android/commit/5b299fd7f7e9d2e4d8d239024ceb13aaac427d99) Merge branch 'main' into feature/PM-5900-fix-for-opening-app-from-notification ### 📊 Changes **1 file changed** (+17 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Services/AndroidPushNotificationService.cs` (+17 -12) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fix for Device Login push notifications causing the app to show HomePage. MAUI is treating the Intent on the push notification as a triggering the creation of a new Activity and we just want to open the existing one. ## Code changes * **AndroidPushNotificationService.cs:** Changed the Intent when tapping the push notification to launch the existing activity instead of creating a new one. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 10:05:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#67891
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?