github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2760] [MERGED] [PM-3839] Fix crash logs and screen capture switches state on appear #67744

New Issue
Closed
opened 2026-05-14 09:55:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 09:55:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2760
Author: @fedemkr
Created: 9/11/2023
Status: ✅ Merged
Merged: 9/18/2023
Merged by: @fedemkr

Base: vault/pm-2658/feature-settings-reorganization ← Head: vault/pm-3839/fix-crash-logs-and-screen-capture-switches

📝 Commits (1)

  • e63d157 PM-3839 Fix allow screen capture and submit crash logs to init their state when the page appears

📊 Changes

3 files changed (+47 additions, -5 deletions)

View changed files

📝 src/App/Pages/Settings/AboutSettingsPage.xaml.cs (+28 -3)
📝 src/App/Pages/Settings/AboutSettingsPageViewModel.cs (+17 -2)
📝 src/App/Pages/Settings/OtherSettingsPageViewModel.cs (+2 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix settings submit crash logs and screen capture switches state when page appears

Code changes

  • AboutSettingsPage/ViewModel: Init should submit crash logs on page appear
  • OtherSettingsPageViewModel: Init is screen capture allowed on page appear

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2760 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 9/11/2023 **Status:** ✅ Merged **Merged:** 9/18/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `vault/pm-2658/feature-settings-reorganization` ← **Head:** `vault/pm-3839/fix-crash-logs-and-screen-capture-switches` --- ### 📝 Commits (1) - [`e63d157`](https://github.com/bitwarden/android/commit/e63d157e25fa0838d253181a1ae2f9130edf10ab) PM-3839 Fix allow screen capture and submit crash logs to init their state when the page appears ### 📊 Changes **3 files changed** (+47 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/AboutSettingsPage.xaml.cs` (+28 -3) 📝 `src/App/Pages/Settings/AboutSettingsPageViewModel.cs` (+17 -2) 📝 `src/App/Pages/Settings/OtherSettingsPageViewModel.cs` (+2 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix settings submit crash logs and screen capture switches state when page appears ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AboutSettingsPage/ViewModel:** Init should submit crash logs on page appear * **OtherSettingsPageViewModel:** Init is screen capture allowed on page appear ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 09:55:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#67744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?