github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 00:56:24 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2312] [MERGED] [SG-460] Master Password security checks (mobile) #67452

New Issue
Closed
opened 2026-05-14 09:36:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 09:36:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2312
Author: @andrebispo5
Created: 1/20/2023
Status: ✅ Merged
Merged: 1/20/2023
Merged by: @andrebispo5

Base: master ← Head: feature/mp-security-checks

📝 Commits (3)

  • 20c0707 [SG-886] MasterPassword Strength Indicator (#2238)
  • 890bae2 [SG-564][SG-565] Check Exposed Password (#2239)
  • 457a8e5 Merge branch 'master' into feature/mp-security-checks

📊 Changes

18 files changed (+553 additions, -31 deletions)

View changed files

📝 src/App/App.csproj (+2 -0)
➕ src/App/Controls/PasswordStrengthProgressBar/IPasswordStrengthable.cs (+11 -0)
➕ src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthCategory.cs (+17 -0)
➕ src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthProgressBar.xaml (+28 -0)
➕ src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthProgressBar.xaml.cs (+107 -0)
➕ src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthViewModel.cs (+67 -0)
📝 src/App/Pages/Accounts/BaseChangePasswordViewModel.cs (+5 -17)
📝 src/App/Pages/Accounts/RegisterPage.xaml (+25 -3)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+83 -7)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+4 -3)
📝 src/App/Pages/BaseViewModel.cs (+6 -0)
📝 src/App/Resources/AppResources.Designer.cs (+108 -0)
📝 src/App/Resources/AppResources.resx (+36 -0)
📝 src/App/Styles/Base.xaml (+11 -0)
➕ src/App/Utilities/ProgressBarExtensions.cs (+25 -0)
📝 src/Core/Abstractions/IPasswordGenerationService.cs (+3 -1)
📝 src/Core/Constants.cs (+1 -0)
📝 src/Core/Services/PasswordGenerationService.cs (+14 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Feature branch with approved PRs, already tested on Android needs to be merged into master to test iOS.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2312 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 1/20/2023 **Status:** ✅ Merged **Merged:** 1/20/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `feature/mp-security-checks` --- ### 📝 Commits (3) - [`20c0707`](https://github.com/bitwarden/android/commit/20c0707224ab7d0abac53f2de27e9c902b572fb7) [SG-886] MasterPassword Strength Indicator (#2238) - [`890bae2`](https://github.com/bitwarden/android/commit/890bae2f9ed9a13b4c39abeb082ea503fcf1fd18) [SG-564][SG-565] Check Exposed Password (#2239) - [`457a8e5`](https://github.com/bitwarden/android/commit/457a8e57acb4a1319aea8b6d0c60978a1de43685) Merge branch 'master' into feature/mp-security-checks ### 📊 Changes **18 files changed** (+553 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+2 -0) ➕ `src/App/Controls/PasswordStrengthProgressBar/IPasswordStrengthable.cs` (+11 -0) ➕ `src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthCategory.cs` (+17 -0) ➕ `src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthProgressBar.xaml` (+28 -0) ➕ `src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthProgressBar.xaml.cs` (+107 -0) ➕ `src/App/Controls/PasswordStrengthProgressBar/PasswordStrengthViewModel.cs` (+67 -0) 📝 `src/App/Pages/Accounts/BaseChangePasswordViewModel.cs` (+5 -17) 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+25 -3) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+83 -7) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+4 -3) 📝 `src/App/Pages/BaseViewModel.cs` (+6 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+108 -0) 📝 `src/App/Resources/AppResources.resx` (+36 -0) 📝 `src/App/Styles/Base.xaml` (+11 -0) ➕ `src/App/Utilities/ProgressBarExtensions.cs` (+25 -0) 📝 `src/Core/Abstractions/IPasswordGenerationService.cs` (+3 -1) 📝 `src/Core/Constants.cs` (+1 -0) 📝 `src/Core/Services/PasswordGenerationService.cs` (+14 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Feature branch with approved PRs, already tested on Android needs to be merged into master to test iOS. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 09:36:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#67452
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?