github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-26 22:04:07 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2305] [MERGED] [PS-2275] Update the default kdf iterations to 600k. #67449

New Issue
Closed
opened 2026-05-14 09:36:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 09:36:26 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2305
Author: @aj-rosado
Created: 1/19/2023
Status: ✅ Merged
Merged: 1/24/2023
Merged by: @aj-rosado

Base: master ← Head: feature/PS-2275-update-kdf-iterations-350k

📝 Commits (3)

  • 1374baf [PS-2275] Update the default kdf iterations to 350k.
  • 54d8b88 Merge branch 'master' into feature/PS-2275-update-kdf-iterations-350k
  • d7a9abe update to 600k per latest owasp

📊 Changes

3 files changed (+6 additions, -7 deletions)

View changed files

📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+2 -3)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+3 -4)
📝 src/Core/Constants.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Updating the KDF iterations to the same value as clients https://github.com/bitwarden/clients/pull/4482
Getting KdfIterations value from a global constant to be used by all the VMs that need it.

Code changes

  • Constants.cs: Added KdfIterations constant value with 600k
  • RegisterPageViewModel.cs, SetPasswordPageViewModel.cs: Using the KdfIterations value from Constants.cs

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2305 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 1/19/2023 **Status:** ✅ Merged **Merged:** 1/24/2023 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `feature/PS-2275-update-kdf-iterations-350k` --- ### 📝 Commits (3) - [`1374baf`](https://github.com/bitwarden/android/commit/1374bafc2d20c37af404505b659a1c5b5daf4d5b) [PS-2275] Update the default kdf iterations to 350k. - [`54d8b88`](https://github.com/bitwarden/android/commit/54d8b88bf4b63e0a277f161686334d5a620d6907) Merge branch 'master' into feature/PS-2275-update-kdf-iterations-350k - [`d7a9abe`](https://github.com/bitwarden/android/commit/d7a9abe4bcebabb4045625378f0010bd6998fc22) update to 600k per latest owasp ### 📊 Changes **3 files changed** (+6 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+2 -3) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+3 -4) 📝 `src/Core/Constants.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Updating the KDF iterations to the same value as clients https://github.com/bitwarden/clients/pull/4482 Getting KdfIterations value from a global constant to be used by all the VMs that need it. ## Code changes * **Constants.cs:** Added `KdfIterations` constant value with 600k * **RegisterPageViewModel.cs, SetPasswordPageViewModel.cs:** Using the `KdfIterations` value from `Constants.cs` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 09:36:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#67449