github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-19 07:55:46 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #6611] [MERGED] PM-33112: Avoid double announcement of BitwardenSwitch content description #63985

New Issue
Closed
opened 2026-05-12 03:28:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 03:28:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6611
Author: @david-livefront
Created: 3/3/2026
Status: ✅ Merged
Merged: 3/4/2026
Merged by: @david-livefront

Base: main ← Head: PM-33112-switch-content-description

📝 Commits (1)

  • 148bdfc PM-33112: Avoid double announcement of BitwardnSwitch content description

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/toggle/BitwardenSwitch.kt (+8 -2)

📄 Description

🎟️ Tracking

PM-33112

📔 Objective

This PR removes a double announcement of BitwardenSwitch labels. The top-level contentDescription will now use either the supplied contentDescription or the label as a fallback, the label text will no longer be announced separately.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6611 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/3/2026 **Status:** ✅ Merged **Merged:** 3/4/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-33112-switch-content-description` --- ### 📝 Commits (1) - [`148bdfc`](https://github.com/bitwarden/android/commit/148bdfccad8559ccc8b64c736b804a617bc5ca21) PM-33112: Avoid double announcement of BitwardnSwitch content description ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/toggle/BitwardenSwitch.kt` (+8 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-33112](https://bitwarden.atlassian.net/browse/PM-33112) ## 📔 Objective This PR removes a double announcement of `BitwardenSwitch` labels. The top-level `contentDescription` will now use either the supplied `contentDescription` or the `label` as a fallback, the `label` text will no longer be announced separately. [PM-33112]: https://bitwarden.atlassian.net/browse/PM-33112?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 03:28:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#63985
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?