github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 19:04:56 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6510] [MERGED] [PM-32011] Add cookie callback flow to AuthRepository #63900

New Issue
Closed
opened 2026-05-12 03:23:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 03:23:53 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6510
Author: @SaintPatrck
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @SaintPatrck

Base: main ← Head: cookie-vending/p5-t8_auth-repo-integration

📝 Commits (1)

  • 3fdc09c [PM-32011] Add cookie callback flow to AuthRepository

📊 Changes

3 files changed (+35 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+12 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+9 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+14 -0)

📄 Description

🎟️ Tracking

PM-32011

📔 Objective

Define observable cookie callback result flow in AuthRepo. This will be used to set and listen for callback results for pending cookie acquisition.

AuthRepository Changes:

  • Added cookieCallbackResultFlow: Flow
  • Added setCookieCallbackResult() method
  • Follows existing ssoCallbackResultFlow pattern

Implementation:

  • Uses bufferedMutableSharedFlow() helper
  • Exposes as Flow (not StateFlow - one-time event)
  • Non-blocking tryEmit() for setter

Tests:

  • Added Turbine flow test
  • Verifies flow emission on setCookieCallbackResult()

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6510 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `cookie-vending/p5-t8_auth-repo-integration` --- ### 📝 Commits (1) - [`3fdc09c`](https://github.com/bitwarden/android/commit/3fdc09c89fc8e70fccfd3587590ca9fbea75d4b3) [PM-32011] Add cookie callback flow to AuthRepository ### 📊 Changes **3 files changed** (+35 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+12 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+9 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+14 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-32011 ## 📔 Objective Define observable cookie callback result flow in AuthRepo. This will be used to set and listen for callback results for pending cookie acquisition. AuthRepository Changes: - Added cookieCallbackResultFlow: Flow<CookieCallbackResult> - Added setCookieCallbackResult() method - Follows existing ssoCallbackResultFlow pattern Implementation: - Uses bufferedMutableSharedFlow() helper - Exposes as Flow (not StateFlow - one-time event) - Non-blocking tryEmit() for setter Tests: - Added Turbine flow test - Verifies flow emission on setCookieCallbackResult() ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 03:23:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#63900