github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #6159] [PM-28086] Add testharness for Credential Manager and Autofill testing #6368

New Issue
Closed
opened 2025-11-27 00:22:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:22:50 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6159

State: closed
Merged: Yes

🎟️ Tracking

PM-28086

📔 Objective

This PR introduces a new :testharness module - a standalone Android application for validating Bitwarden's Credential Manager provider implementation.

Purpose:
The test harness allows developers to exercise and verify all Credential Manager API operations that the Bitwarden app supports as a credential provider:

  • Password Operations: Create and retrieve password credentials via CreatePasswordRequest and GetPasswordOption
  • Passkey Operations: Create and retrieve passkeys via CreatePublicKeyCredentialRequest and GetPublicKeyCredentialOption
  • Combined Operations: Test hybrid flows that accept both passwords and passkeys

Architecture:
The module follows the same patterns as :app and :authenticator:

  • MVVM + UDF architecture with BaseViewModel
  • Hilt dependency injection throughout
  • Jetpack Compose UI with Material 3
  • Comprehensive unit test coverage (ViewModels, Screens, and data layer)

Integration:
The test harness acts as a credential consumer client, triggering the system credential picker and allowing selection of Bitwarden as the provider. This enables end-to-end validation of credential flows without relying on external websites or apps.

Build Configuration:
Added :testharness to detekt (static analysis) and kover (code coverage) configurations in root build.gradle.kts.

Requirements: API 28+ (uses AndroidX Credentials library with Play Services compatibility)

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6159 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-28086 ## 📔 Objective This PR introduces a new `:testharness` module - a standalone Android application for validating Bitwarden's Credential Manager provider implementation. **Purpose:** The test harness allows developers to exercise and verify all Credential Manager API operations that the Bitwarden app supports as a credential provider: - **Password Operations**: Create and retrieve password credentials via `CreatePasswordRequest` and `GetPasswordOption` - **Passkey Operations**: Create and retrieve passkeys via `CreatePublicKeyCredentialRequest` and `GetPublicKeyCredentialOption` - **Combined Operations**: Test hybrid flows that accept both passwords and passkeys **Architecture:** The module follows the same patterns as `:app` and `:authenticator`: - MVVM + UDF architecture with `BaseViewModel` - Hilt dependency injection throughout - Jetpack Compose UI with Material 3 - Comprehensive unit test coverage (ViewModels, Screens, and data layer) **Integration:** The test harness acts as a credential consumer client, triggering the system credential picker and allowing selection of Bitwarden as the provider. This enables end-to-end validation of credential flows without relying on external websites or apps. **Build Configuration:** Added `:testharness` to detekt (static analysis) and kover (code coverage) configurations in root `build.gradle.kts`. **Requirements:** API 28+ (uses AndroidX Credentials library with Play Services compatibility) ## 📸 Screenshots Coming soon! ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:22:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6368
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?