github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #6134] [PM-27901] Add f-droid fastlane metadata #6346

New Issue
Closed
opened 2025-11-27 00:22:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:22:35 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6134

State: closed
Merged: Yes

🎟️ Tracking

PM-27901

📔 Objective

Add required fastlane metadata for the f-droid build to support the distribution of Password Manager in the main f-droid repo, as requested in https://gitlab.com/fdroid/fdroiddata/-/merge_requests/19550#note_2770875171. Focusing on the required text files for the time being, we can later expand it with by adding the optional content.

File Location

File location documentation: https://gitlab.com/-/snippets/1895688#locations

In this PR we're going with the third option given our monorepo, providing metadata specific to the Password Manager f-droid app build without affecting Authenticator.

For F-Droid, there are 3 possible entry-points the process looks for Fastlane, always located in the root of the app's repository:

/fastlane/metadata/android/<locale>/
/metadata/<locale>/
/src/<buildFlavor>/fastlane/metadata/android/<locale>/

Folder Structure Reference

From https://gitlab.com/-/snippets/1895688#structure:

Items marked with ¹ are the minimum requirements (i.e. must be there), ² means "strongly recommended". Consider all others optional, and ³ nice to have:

/                                           (repo-root)
└── fastlane
    └── metadata
        └── android
            ├── en-US                       (en-US seems to be required by F-Droid)
            │   ├── short_description.txt   (short description, max 80 chars, plain text) ¹
            │   ├── full_description.txt    (full app description, max 4000 chars, basic HTML allowed) ¹
            │   ├── title.txt               (app name)
            │   ├── video.txt               (URL to a video introducing the app)
            │   ├── images
            │   │   ├── icon.png            (app icon; useful e.g. for "service apps" containing none)
            │   │   ├── featureGraphic.png  (promo banner, shown on top of the app desc in F-Droid client; landscape) ³
            │   │   ├── promoGraphic.png    (same, smallscreen size?)
            │   │   ├── tvBanner.png        (same, TV-screen size?)
            │   │   ├── phoneScreenshots    ²
            │   │   │   ├── 1.png
            │   │   │   ├── 2.png
            │   │   │   ...
            │   │   ├── sevenInchScreenshots/
            │   │   ├── tenInchScreenshots/
            │   │   ├── tvScreenshots/
            │   │   └── wearScreenshots/
            │   └── changelogs              ³
            │       ├── 100000.txt          (must correspond to versionCode, literally, no padding)
            │       ├── 100100.txt          (so this means: versionCode=100100)
            │       └── 100101.txt          (max size: 500 bytes, plain ASCII (no HTML))
            └── ru
                ...
                └── changelogs
                    └── 100100.txt

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6134 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-27901 ## 📔 Objective Add required fastlane metadata for the f-droid build to support the distribution of Password Manager in the main f-droid repo, as requested in https://gitlab.com/fdroid/fdroiddata/-/merge_requests/19550#note_2770875171. Focusing on the required text files for the time being, we can later expand it with by adding the optional content. ### File Location File location documentation: https://gitlab.com/-/snippets/1895688#locations In this PR we're going with the third option given our monorepo, providing metadata specific to the Password Manager f-droid app build without affecting Authenticator. ``` For F-Droid, there are 3 possible entry-points the process looks for Fastlane, always located in the root of the app's repository: /fastlane/metadata/android/<locale>/ /metadata/<locale>/ /src/<buildFlavor>/fastlane/metadata/android/<locale>/ ``` ### Folder Structure Reference From https://gitlab.com/-/snippets/1895688#structure: ``` Items marked with ¹ are the minimum requirements (i.e. must be there), ² means "strongly recommended". Consider all others optional, and ³ nice to have: / (repo-root) └── fastlane └── metadata └── android ├── en-US (en-US seems to be required by F-Droid) │ ├── short_description.txt (short description, max 80 chars, plain text) ¹ │ ├── full_description.txt (full app description, max 4000 chars, basic HTML allowed) ¹ │ ├── title.txt (app name) │ ├── video.txt (URL to a video introducing the app) │ ├── images │ │ ├── icon.png (app icon; useful e.g. for "service apps" containing none) │ │ ├── featureGraphic.png (promo banner, shown on top of the app desc in F-Droid client; landscape) ³ │ │ ├── promoGraphic.png (same, smallscreen size?) │ │ ├── tvBanner.png (same, TV-screen size?) │ │ ├── phoneScreenshots ² │ │ │ ├── 1.png │ │ │ ├── 2.png │ │ │ ... │ │ ├── sevenInchScreenshots/ │ │ ├── tenInchScreenshots/ │ │ ├── tvScreenshots/ │ │ └── wearScreenshots/ │ └── changelogs ³ │ ├── 100000.txt (must correspond to versionCode, literally, no padding) │ ├── 100100.txt (so this means: versionCode=100100) │ └── 100101.txt (max size: 500 bytes, plain ASCII (no HTML)) └── ru ... └── changelogs └── 100100.txt ``` ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:22:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?