github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #6128] Refine reviewing-changes skill to eliminate verbosity and praise #6340

New Issue
Closed
opened 2025-11-27 00:22:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:22:31 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6128

State: closed
Merged: Yes

🎟️ Tracking

N/A

📔 Objective

Refines the reviewing-changes skill to address verbosity and excessive complimentary feedback identified in recent PR
reviews. The skill was generating 800+ token summaries with multiple sections (Strengths, Recommendations, Test
Coverage Status, Architecture Compliance) and creating praise-only inline comments that cluttered PR conversations
without providing actionable feedback.

Key improvements:

  • Mandates <details> tags for all inline comments - only severity + one-line description visible, all details
    collapsed
  • Eliminates praise-only comments - explicit prohibition against creating inline comments solely for positive feedback
  • Simplifies summary format - scales with PR complexity (simple PRs = 3-5 lines, complex PRs = add brief context
    paragraph)
  • Adds thread detection - new Step 1 checks existing PR comments to prevent duplicate findings when re-reviewing
  • Consolidates examples file - reduced from ~7,570 to ~1,700 tokens (77% reduction) by removing redundant format
    guidance that duplicated SKILL.md content
  • Aligns format - resolves contradiction between SKILL.md and examples, both now use summary + inline comments
    approach
  • Updates severity prefixes - hybrid emoji + text format (⚠️ CRITICAL, 📋 IMPORTANT, 💡 SUGGESTED, ❓ QUESTION) for
    visual scanning + searchability

Impact: Reviews will be more concise, focused exclusively on actionable issues, visually cleaner in PR conversations,
and avoid spamming duplicate comments on re-reviews. Net reduction of 3,500 tokens (13%) in total skill context while
maintaining comprehensive review capability.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6128 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking N/A ## 📔 Objective Refines the reviewing-changes skill to address verbosity and excessive complimentary feedback identified in recent PR reviews. The skill was generating 800+ token summaries with multiple sections (Strengths, Recommendations, Test Coverage Status, Architecture Compliance) and creating praise-only inline comments that cluttered PR conversations without providing actionable feedback. Key improvements: - Mandates `<details>` tags for all inline comments - only severity + one-line description visible, all details collapsed - Eliminates praise-only comments - explicit prohibition against creating inline comments solely for positive feedback - Simplifies summary format - scales with PR complexity (simple PRs = 3-5 lines, complex PRs = add brief context paragraph) - Adds thread detection - new Step 1 checks existing PR comments to prevent duplicate findings when re-reviewing - Consolidates examples file - reduced from ~7,570 to ~1,700 tokens (77% reduction) by removing redundant format guidance that duplicated SKILL.md content - Aligns format - resolves contradiction between SKILL.md and examples, both now use summary + inline comments approach - Updates severity prefixes - hybrid emoji + text format (⚠️ CRITICAL, 📋 IMPORTANT, 💡 SUGGESTED, ❓ QUESTION) for visual scanning + searchability Impact: Reviews will be more concise, focused exclusively on actionable issues, visually cleaner in PR conversations, and avoid spamming duplicate comments on re-reviews. Net reduction of 3,500 tokens (13%) in total skill context while maintaining comprehensive review capability. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:22:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6340
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?