github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 17:16:20 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #4845] [MERGED] PM-11356 prevent extra soft-keyboard showing. #62520

New Issue
Closed
opened 2026-05-12 01:51:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 01:51:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4845
Author: @dseverns-livefront
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-11356-extra-keyboard

📝 Commits (3)

  • a22a44f PM-11356 delay the autofocus on password field on the unlock screen to account for garbage collection
  • 41d4edd update test to account for delay
  • 092564c comment language

📊 Changes

2 files changed (+20 additions, -2 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt (+16 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt (+4 -1)

📄 Description

🎟️ Tracking

PM-11356

📔 Objective

  • When the user account and unlocked status change we trigger the garbage collection which causes the screen to completely compose twice, which causes the focus request on the text field to happen twice which is the cause of the "extra" keyboard showing.
  • Adding a small delay means the first attempt to draw the screen that will ultimately get garbage collected will not show the keyboard as the text field will not autofocus.

📸 Screenshots

BEFORE:

https://github.com/user-attachments/assets/0f099687-3232-46e0-98ee-bf5afc6970cc

AFTER

https://github.com/user-attachments/assets/e109d8f6-d9e9-42ec-9a99-fdcf3f1043e5

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4845 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-11356-extra-keyboard` --- ### 📝 Commits (3) - [`a22a44f`](https://github.com/bitwarden/android/commit/a22a44f26a012667b62f08fe9cad7000a7b91813) PM-11356 delay the autofocus on password field on the unlock screen to account for garbage collection - [`41d4edd`](https://github.com/bitwarden/android/commit/41d4eddf52bad97cfc4430b4d21eaac99e47b572) update test to account for delay - [`092564c`](https://github.com/bitwarden/android/commit/092564c862ca961c1ed2f247ed3a841094dad8ee) comment language ### 📊 Changes **2 files changed** (+20 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt` (+16 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt` (+4 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-11356](https://bitwarden.atlassian.net/browse/PM-11356) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - When the user account and unlocked status change we trigger the garbage collection which causes the screen to completely compose twice, which causes the focus request on the text field to happen twice which is the cause of the "extra" keyboard showing. - Adding a small delay means the first attempt to draw the screen that will ultimately get garbage collected will not show the keyboard as the text field will not autofocus. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots # BEFORE: https://github.com/user-attachments/assets/0f099687-3232-46e0-98ee-bf5afc6970cc # AFTER https://github.com/user-attachments/assets/e109d8f6-d9e9-42ec-9a99-fdcf3f1043e5 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-11356]: https://bitwarden.atlassian.net/browse/PM-11356?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 01:51:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#62520
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?