[PR #6029] Add agent guidelines and role definitions (summon Kabal) #6251

Closed
opened 2025-11-27 00:21:27 -06:00 by GiteaMirror · 0 comments
Owner

Original Pull Request: https://github.com/bitwarden/android/pull/6029

State: closed
Merged: No


🎟️ Tracking

N/A

📔 Objective

This commit introduces a comprehensive set of guidelines and role definitions for an AI agent-based workflow tailored for the Bitwarden Android project. These documents are designed to ensure consistency, maintainability, and adherence to project standards.

The core changes include:

  • /.claude/CLAUDE.md: Adds the main guidelines document. It defines the default agent persona (KABAL), the agent-based workflow, core directives, and summaries of the project's architecture, code style, testing practices, and commit message structure.

  • /.claude/agents/: Introduces a new directory containing detailed role definitions for specialized agents in the development lifecycle:

    • requirements-analyst.md: Defines the "ATLAS" agent, responsible for analyzing requirements and defining what needs to be built.
    • threat-assessor.md: Defines the "TALOS" agent, responsible for performing threat modeling and security analysis.
    • android-architect.md: Defines the "ANDI" agent, responsible for designing the system architecture and defining how to build it.
    • implementer.md: Defines the "FORGE" agent, responsible for writing production Kotlin code.
    • android-tester.md: Defines the "QAID" agent, responsible for writing unit tests to validate the implementation.
    • documenter.md: Defines the "SAGA" agent, responsible for creating and updating project documentation.

Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6029 **State:** closed **Merged:** No --- ## 🎟️ Tracking N/A ## 📔 Objective This commit introduces a comprehensive set of guidelines and role definitions for an AI agent-based workflow tailored for the Bitwarden Android project. These documents are designed to ensure consistency, maintainability, and adherence to project standards. The core changes include: * **`/.claude/CLAUDE.md`**: Adds the main guidelines document. It defines the default agent persona (KABAL), the agent-based workflow, core directives, and summaries of the project's architecture, code style, testing practices, and commit message structure. * **`/.claude/agents/`**: Introduces a new directory containing detailed role definitions for specialized agents in the development lifecycle: * **`requirements-analyst.md`**: Defines the "ATLAS" agent, responsible for analyzing requirements and defining what needs to be built. * **`threat-assessor.md`**: Defines the "TALOS" agent, responsible for performing threat modeling and security analysis. * **`android-architect.md`**: Defines the "ANDI" agent, responsible for designing the system architecture and defining how to build it. * **`implementer.md`**: Defines the "FORGE" agent, responsible for writing production Kotlin code. * **`android-tester.md`**: Defines the "QAID" agent, responsible for writing unit tests to validate the implementation. * **`documenter.md`**: Defines the "SAGA" agent, responsible for creating and updating project documentation. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:21:27 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6251