[PR #5948] [PM-26315] Register/unregister for CXP export based on feature flag #6178

New Issue

GiteaMirror · 2025-11-27T00:20:37-06:00

GiteaMirror commented

2025-11-27 00:20:37 -06:00

Original Pull Request: https://github.com/bitwarden/android/pull/5948

State: closed
Merged: Yes

🎟️ Tracking

N/A

📔 Objective

This commit updates the Credential Exchange Protocol (CXP) export registration to be app-scoped rather than per-user.

Key changes:

Unregister the app for CXP export on logout if it's the last remaining account.
Unregister for CXP export when the feature flag is disabled, and register when it's enabled.
Introduce CredentialExchangeRegistryManager to handle CXP registration and unregistration logic.
Update isVaultRegisteredForExport to isAppRegisteredForExport to reflect the app-wide scope.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

**Original Pull Request:** https://github.com/bitwarden/android/pull/5948 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking N/A ## 📔 Objective This commit updates the Credential Exchange Protocol (CXP) export registration to be app-scoped rather than per-user. Key changes: - Unregister the app for CXP export on logout if it's the last remaining account. - Unregister for CXP export when the feature flag is disabled, and register when it's enabled. - Introduce `CredentialExchangeRegistryManager` to handle CXP registration and unregistration logic. - Update `isVaultRegisteredForExport` to `isAppRegisteredForExport` to reflect the app-wide scope. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes

GiteaMirror added the pull-request label 2025-11-27 00:20:37 -06:00

GiteaMirror closed this issue